1251115 - Draw SVG correctly when mask url can not be resolved.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

According to bug 1243734 comment 32 and bug 1243734 comment 34, file an independent bug to fix this issue.

When the path of a mask attribute is not resolvable, nsSVGIntegrationUtils::PaintFramesWithEffects may generate a wrong mask.

Here is an example of mask not resolvable.
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/svg/mask-basic-01.svg

Comment 1

[u459114]

Attachment: MozReview Request: Bug 1251115 - Fix incorrect rendering result while mask path is not resolvable.

Review commit: https://reviewboard.mozilla.org/r/36513/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36513/

Comment 2

[u459114]

Comment on attachment 8723383 [details]
MozReview Request: Bug 1251115 - Fix incorrect rendering result while mask path is not resolvable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36513/diff/1-2/

Comment 3

[u459114]

Hi Markus,
Please help to review this patch.
This patch is simply fixing a logic error I made in bug 686281
Under the condition that we have no valid mask images(for example, url of all mask-image are not resolvable), we don't need to generate maskSurface at all.

This bug need to be fixed before we can land the patches in bug 1245499 and bug 1243734.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8723383 [details]
MozReview Request: Bug 1251115 - Fix incorrect rendering result while mask path is not resolvable.

https://reviewboard.mozilla.org/r/36513/#review33123

::: layout/svg/nsSVGIntegrationUtils.cpp:524
(Diff revision 2)
> +  bool hasMaskToDraw = svgMaskFrame ? true : false;

I'd write this as hasMaskToDraw = (svgMaskFrame != nullptr).

Comment 5

[u459114]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb7e82deef8c70722397416bba1d0e9882e37e8
Bug 1251115 - Fix incorrect rendering result while mask path is not resolvable; r=mstange

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for android reftest failures: https://treeherder.mozilla.org/logviewer.html#?job_id=22485930&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/f73ac870683a

Comment 7

[u459114]

Yes, please.

Comment 8

[u459114]

Fix and try
https://hg.mozilla.org/try/rev/7f63272838cd

Comment 9

[u459114]

Fix and try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0584db88c11

Comment 10

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/07438c9bfc83

Comment 11

[u459114]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f73aa13cfa3ec6f38be79a2a39ccced6a0697974
Bug 1251115 - Fix incorrect rendering result while mask path is not resolvable; r=mstange

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f73aa13cfa3e