1251275 - Use AutoEntryScript for firing setTimeout/setInterval callbacks on workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Currently we manually report exceptions here.  We do have an AutoEntryScript set up already from Run (the caller of TimerRunnable::WorkerRun), but we really want a separate one for each timeout callback we run.  This also allows us to provide a better execution reason string.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Switch to using an AutoEntryScript in WorkerPrivate::RunExpiredTimeouts

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Diff -w for review convenience

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch, but with the obvious TakeOwnershipOfErrorReporting() we need

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Diff -w

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8723702 [details] [diff] [review]
Patch, but with the obvious TakeOwnershipOfErrorReporting() we need

Review of attachment 8723702 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.cpp
@@ +5963,5 @@
> +      reason = "setInterval handler";
> +    } else {
> +      reason = "setTimeout handler";
> +    }
> +    { // scope for the AutoEntryScript, so it comes off the stack before we do

nit: \n between the two scopes

Comment 6

[Boris Zbarsky [:bzbarsky]]

> nit: \n between the two scopes

Done.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c10b6b14fce1

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c10b6b14fce1