1251511 - update verify override some variables

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

See https://tools.taskcluster.net/task-inspector/#rBJlzZ-ZSuKgmQGD4bS89g/

Looks like the script expects it coming from command line (buildbot's ScriptFactory) as 5th argument, but we pass only 4. I actually thought that we are going to pass those via properties.

Comment 1

[Rail Aliiev [:rail]]

http://archive.mozilla.org/pub/firefox/tinderbox-builds/date-win64/release-date_win64_update_verify_date_6-bm72-build1-build8.txt.gz

+ '[' -z 1 ']'
++ python /c/builds/moz2_slave/rel-date_w64_u_v_date_6-000000/scripts/scripts/release/updates/../../../buildfarm/utils/jsontool.py -k properties.slavebuilddir /c/builds/moz2_slave/rel-date_w64_u_v_date_6-000000/buildprops.json
Traceback (most recent call last):
  File "c:/builds/moz2_slave/rel-date_w64_u_v_date_6-000000/scripts/scripts/release/updates/../../../buildfarm/utils/jsontool.py", line 25, in <module>
    v = v[k]
KeyError: 'slavebuilddir'
+ SLAVEBUILDDIR=
program finished with exit code 1

Comment 2

[Rail Aliiev [:rail]]

Attachment: props.diff

It turns out that JSONTOOL exits with code zero if prop file is not passed. It shouldn't be used in TC.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8723960 [details] [diff] [review]
props.diff

Review of attachment 8723960 [details] [diff] [review]:
-----------------------------------------------------------------

I thought I tested that! But o well, here we go - thanks

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8723960 [details] [diff] [review]
props.diff

https://hg.mozilla.org/build/tools/rev/fe0f77b7618a