1251605 - System add-on update does not apply if firefox crashes after update and no previous restart is done

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect, P4)

Description

[Bogdan Maris, Desktop QA]

[Affected versions]:
- Firefox 45 beta 9 build 2

[Affected platforms]:
- Windows 7 64bit
- Windows 10 64bit
- Mac OS X 10.11.1
- Ubuntu 14.04 32bit

[Steps to reproduce]:
1. Go to channel-prefs.js in Firefox installation folder and change the value of app.update.channel from 'beta' to 'beta-sysaddon'
2. Save the file and reopen Firefox
3. Visit https://addons.mozilla.org/en-US/firefox/addon/timer-fire/ and install the add-on
4. Visit http://people.mozilla.org/~tmielczarek/crashme/ and install the add-on (change 'xpinstall.signatures.required' to 'false' if add-on can't be installed)
5. Force the auto update: Tools > Fire Timer > Add-on Update
6. After the update is downloaded crash Firefox: Tools > Crash me!
7. Restart Firefox or Quit -> Start Firefox
8. Go to about:support and look for loop version

[Expected result]:
- Version 0.1.2 is displayed in about:support

[Actual result]:
- Version 0.1 is displayed in about:support

[Regression range]:
- Not a regression since this test update is only available in Firefox 45 beta 9 but once goes live it will impact Firefox 45.

[Additional notes]:
- If step 5 is run again and after the update the user restarts Firefox, the update will be successfully applied (version 0.1.2)
- I don't consider this blocker since is unlikely that Firefox will crash again after the second update is applied, but should be looked at.

Comment 1

[Mark Banner (:standard8)]

This code is in Toolkit, so moving to what I think is the right place.

Comment 2

[Dave Townsend [:mossop]]

We would need to flush prefs to disk after installing the update to survive the crash. As long as we remain in a consistent state I'm less concerned though.

Comment 3

[Bogdan Maris, Desktop QA]

Updated the tracking flags based on comment 0 (Only Firefox 45 is affected).

Comment 4

[Dave Townsend [:mossop]]

Specifically we should call Services.prefs.savePrefFile(null) after we do the system add-on update.

I bet you could do this Andrew!

Comment 5

[Mark Banner (:standard8)]

Altering title, as I expect this still applies to other system add-ons.

Comment 6

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.