1251856 - U2F-related test_interfaces.html is going to permafail when Gecko 47 merges to Beta

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Merge day permafail.

Looks like test_interfaces.html needs to be updated.

https://treeherder.mozilla.org/logviewer.html#?job_id=17314340&repo=try

TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface U2F to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Comment 1

[J.C. Jones [:jcj] (he/him)]

Ryan: I guess this is what Baku was referring to in the last line of https://bugzilla.mozilla.org/show_bug.cgi?id=1231681#c14 about build-specific #ifdefs, though I'm still unclear as to the correct resolution.

The semantics we want is for window.u2f to be opt-in via pref on all builds, for the foreseeable future. What do I need to do to make that true?

Comment 2

[J.C. Jones [:jcj] (he/him)]

Attachment: MozReview Request: Bug 1251856 - Disable U2F in all releases (fix for 1231681) r?baku

* Pref off the "U2F" interface to blank out the integer constants, and
* Disable U2F in all releases.

Review commit: https://reviewboard.mozilla.org/r/37157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37157/

Comment 3

[J.C. Jones [:jcj] (he/him)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7c145e31d2c&selectedJob=17364033

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8724786 [details]
MozReview Request: Bug 1251856 - Disable U2F in all releases (fix for 1231681) r?baku

https://reviewboard.mozilla.org/r/37157/#review33943

::: dom/webidl/U2F.webidl:71
(Diff revision 1)
> +[Pref="security.webauth.u2f"]

is this pref set to false somewhere?

Comment 5

[J.C. Jones [:jcj] (he/him)]

Thanks for the review, baku!

Comment 6

[J.C. Jones [:jcj] (he/him)]

https://reviewboard.mozilla.org/r/37157/#review33943

> is this pref set to false somewhere?

Yes, in `netwerk/base/security-prefs.js` it's set false. :)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c029ca3348a

Comment 8

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/c5f11d429e6b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c029ca3348a

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Don't feel the need to track this since it's fixed.