1251875 - Remove the dom.serviceWorkers.interception.enabled pref

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

I'd like to do this now, since we won't go back to the state where we want to ship the API but unship the actual interception.  Any objections, Ben?

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

We need the pref for 45esr, but OK removing it in 47+.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8724894 [details] [diff] [review]
Patch (v1)

Review of attachment 8724894 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if it passes a try build.

Want to do a P2 patch to remove the opaque interception pref?

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug 1251875, Remove the dom.serviceWorkers.interception.enabled pref, has been reviewed.

An engineer is working on this bug.

You will receive emailed updates on the progress of your bug’s fix from Bugzilla, so make sure that [e-mail] is not blocked in your spam filters.

Thank you.

Comment 5

[(no longer active)]

> Want to do a P2 patch to remove the opaque interception pref?

Yep, will do!

Comment 6

[(no longer active)]

Attachment: Part 2: Remove the dom.serviceWorkers.interception.opaque.enabled pref

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8725041 [details] [diff] [review]
Part 2: Remove the dom.serviceWorkers.interception.opaque.enabled pref

Review of attachment 8725041 [details] [diff] [review]:
-----------------------------------------------------------------

We should remove the l10n string from dom.properties, bit otherwise looks good.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a83057f5e96d
https://hg.mozilla.org/integration/mozilla-inbound/rev/7729ce5fd356

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a83057f5e96d
https://hg.mozilla.org/mozilla-central/rev/7729ce5fd356

Comment 10

[jwms]

Still present in Fennec nightly v57