Closed Bug 1251883 Opened 8 years ago Closed 6 years ago

Remove remaining Cu.importGlobalProperties from devtools

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: pbro, Unassigned)

Details

In bug 1223452 Tom removed a bunch of Cu.importGlobalProperties.
Today I found 2 more:

\devtools\server\actors\device.js:
   15: Cu.importGlobalProperties(["FileReader"]);

\devtools\server\actors\webapps.js:
   14: Cu.importGlobalProperties(["FileReader"]);

We should get rid of these too I guess.

Tom, what do you suggest we replace these with?
Flags: needinfo?(ttromey)
I would like to work on this after Tom specifies what the replacement is.
I think the simplest thing is to make a new "FileReader" module in Loader.jsm.
You can follow the CSS example here:

https://dxr.mozilla.org/mozilla-central/source/devtools/shared/Loader.jsm#70

I really thought I had gotten all the calls; kind of surprised that this
wasn't found during bug 1224289.
Flags: needinfo?(ttromey)
As far as I can see, these are removed now, so there's nothing left to do here.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.