1252368 - Move resource files in layout/style/ into res/ directory

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Per bug 1097398 comment 122:
heycam: In the future we might want to move the other res/ resource files into the res/ directory, just to avoid cluttering up layout/style/.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

heycam, do you want to be a mentor for this bug?

Comment 2

[Nick Alexander :nalexander [he/him]]

This ticket tracks making https://dxr.mozilla.org/mozilla-central/source/layout/style/jar.mn a little more uniform.  There are some resources in layout/style/res, and many that are not.  Use |hg mv| to move the ones in layout/style into res/, and then update the jar.mn file to point to the new locations.

Perhaps a layout peer can suggest how to view one of these resources, to make sure that the move has succeeded.

Comment 3

[Vishnu (:malayaleecoder)]

Nick, Can I take this up :)
To make sure that the move has been succeeded, I think you would have to do a try push for me(I am still having problems with try)

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to malayaleecoder from comment #3)
> Nick, Can I take this up :)
> To make sure that the move has been succeeded, I think you would have to do
> a try push for me(I am still having problems with try)

Certainly.  I can help with try, too :)

Comment 5

[Vishnu (:malayaleecoder)]

Attachment: Bug1252368_v1.diff

Nick, have a look. Please do a try push if you feel it is necessary(As I did not build it).

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to malayaleecoder from comment #5)
> Created attachment 8729134 [details] [diff] [review]
> Bug1252368_v1.diff
> 
> Nick, have a look. Please do a try push if you feel it is necessary(As I did
> not build it).

You haven't moved the files in the directory structure with |hg mv|.  You should at least test locally: just |mach build| would fail, since this is broken.  We can work on getting try access fixed eventually.

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8729134 [details] [diff] [review]
Bug1252368_v1.diff

Review of attachment 8729134 [details] [diff] [review]:
-----------------------------------------------------------------

Gah, splinter hides the renamed files.  This is looking good, but might require a clobber.  Let's try it without!

Comment 8

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca5a2cc0d3f4

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8c4c8f3f6379

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c4c8f3f6379