1252766 - Remove MediaDecoderStateMachine::mDecodeToSeekTarget

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

After fixing bug 1252762, mDecodeToSeekTarget is not used and can be removed.

Comment 1

[Jean-Yves Avenard [:jya]]

AFAICT, it is currently used.

mDecodeToSeekTarget is used to determine if when state == DECODER_STATE_SEEKING and if so if we need to continue decoding until we reach the target.

It is set to false but MDSM::SeekComplete() may stay in DECODER_STATE_SEEKING if a new seek was started before the current one completing.

Can probably modify the logic so we don't we need, but the title of this bug indicates that it's not used, and right now it is.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

It won't after fixing bug 1252762. When writing patches for bug 1252762, it turned out mDecodeToSeekTarget is never read and can be removed safely.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1252766 - Remove MediaDecoderStateMachine::mDecodeToSeekTarget which is never read. r=kaku.

Review commit: https://reviewboard.mozilla.org/r/38081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38081/

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8726553 [details]
MozReview Request: Bug 1252766 - Remove MediaDecoderStateMachine::mDecodeToSeekTarget which is never read. r=kaku.

https://reviewboard.mozilla.org/r/38081/#review34615

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d994749000ad

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d994749000ad