1252936 - Port ValueSelector refactor from System to TV System

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

In bug 1235975 we migrated System app to use modern L10n API and work with RTL languages.

We need to port those changes to TV System so that we can migrate TV System to l20n.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1252936-migrate-smart-system-value-selector-to-modern-l10n > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8725765 [details] [review]
[gaia] zbraniecki:1252936-migrate-smart-system-value-selector-to-modern-l10n > mozilla-b2g:master

Ok, since this is the last functional change needed to finish transitioning TV to L20n, and :albertopq is not sure if we'll be able to just switch TV to System's ValueSelector, I ported manually the changes.

This patch removes the mozL10n.get calls, and makes the value selector work with RTL languages and non-latin digit-systems.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8725765 [details] [review]
[gaia] zbraniecki:1252936-migrate-smart-system-value-selector-to-modern-l10n > mozilla-b2g:master

As far as I know we didn't make significant changes to value selector and data pickers, so it should be OK to port them here directly.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Sorry I happenly pressed the merge button so it's here:
https://github.com/mozilla-b2g/gaia/commit/74808d450c109ffa421388fc9986c672ebd9bc76

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

ok, cool! :) Thanks!