Closed Bug 1253161 Opened 8 years ago Closed 8 years ago

Replace reminder macros in libssl

Categories

(NSS :: Libraries, defect)

Product:
NSS
Component:
Libraries
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox47 --- affected

People

(Reporter: mt, Assigned: mt)

Details

These macros need auditing for correctness.  They all indicate potential bugs; or wooly code.

#define SET_ERROR_CODE    /* reminder */
#define SEND_ALERT        /* reminder */
#define TEST_FOR_FAILURE  /* reminder */
#define DEAL_WITH_FAILURE /* reminder */
Tim, see http://codereview.appspot.com/291500043
Flags: needinfo?(ttaubert)
I'm going to come back to this once my big DHE patch is done.  The two will conflict and this isn't important.
Flags: needinfo?(ttaubert)
Assignee: nobody → martin.thomson
Updated review link: https://codereview.appspot.com/307290043
I'd like to land this one some time.
Flags: needinfo?(ttaubert)
Sorry, closed this tab somehow :/ Will review ASAP.
Flags: needinfo?(ttaubert)
Flags: needinfo?(ttaubert)
LGTM
Flags: needinfo?(ttaubert)
https://hg.mozilla.org/projects/nss/rev/4553276f3873
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.28
You need to log in before you can comment on or make changes to this bug.