1253333 - Race condition in NotifyFinished() - called after MediaManager shuts down

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

The AsyncShutdown hang I started hitting in bug 1250934 was due to a race where NotifyFinished (from MSG) happened after MediaManager shuts down.  Calling Get() was causing a second MediaManager to be created, which we have an assert for in debug.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

MOZ_RELEASE_ASSERT is the bomb.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Don't cause a second MediaManager to be created if there's a race with NotifyFinished

MozReview-Commit-ID: J4GArKKncYx

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8726286 [details] [diff] [review]
Don't cause a second MediaManager to be created if there's a race with NotifyFinished

Review of attachment 8726286 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. It's a little troubling knowing stuff is going on this late.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42356eefad43

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42356eefad43