Closed
Bug 1253404
Opened 8 years ago
Closed 8 years ago
Add itsatrap test for Safe Browsing -block- list
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: cpeterson, Assigned: tschneider)
References
Details
Attachments
(2 files)
François recommends forking [1] and modifying it to use the entries that will be hardcoded into the blocklist. Once your pull request against that repo is accepted, the test page will be automatically deployed at https://itisatrap.org/firefox/blocked.html [1] https://github.com/mozilla/itisatrap/blob/master/firefox/its-a-tracker.html
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8736934 -
Flags: review?(francois)
Comment 2•8 years ago
|
||
Once you're happy with the wording, I recommend getting Matej to review it quickly. When I did that for the forbidden lists in bug 1216727, I attached a screenshot of the test page and flagged Matej for review on the screenshot.
Updated•8 years ago
|
Attachment #8736934 -
Flags: review?(francois)
Comment 3•8 years ago
|
||
Matej, here's another test page for itisatrap.org. Is there anything you'd like us to change in the copy?
Attachment #8738300 -
Flags: review?(matej)
Comment 4•8 years ago
|
||
Comment on attachment 8738300 [details]
Screenshot of the new page
Looks fine to me. Thanks.
Attachment #8738300 -
Flags: review?(matej) → review+
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•