Closed Bug 125346 Opened 23 years ago Closed 23 years ago

There is an extra text box in the link properties box; edit fields won't accept caret

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows ME
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: dslmichael, Assigned: cmanske)

Details

Attachments

(1 file, 2 obsolete files)

One more try!
752 bytes, patch
cmanske
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review 
If you try to edit a link in composer, you will notice that there is an extra
text box, and if you try to edit the box, and save the changes, nothing happens.

Steps to Reproduce:
1. Launch Composer
2. Click on the link icon on the toolbar
3. Enter text for the link text and link location, and click on OK
4. Double click on the link to bring the link properties dialog back up

Actual Results:
There is an extra text box under the link text, and if you type something in
there and click on OK, no change is made to the page.

Expected Results:
I would expect that this box is not there, or if it is there, that making
changes to it would somehow change the page.

Note:  This started on trunk build 02-09, and is still happening on the 02-13
trunk build.
-->cmanske
Assignee: syd → cmanske
Keywords: nsbeta1+, regression
Whiteboard: EDITORBASE
Target Milestone: --- → mozilla0.9.9
I can't reproduce this!

Ok, I see it now. I had a fix for another bug that was hiding this!
Status: NEW → ASSIGNED
Attached patch Fix (obsolete) — — Splinter Review 

    
  
Keywords: patch, 
          
            review
Whiteboard: EDITORBASE → EDITORBASE+, FIX IN HAND, need r=,sr=

    
    

    
  
The fix for this is identical to that for bug 103197. Not exactly a dup; more of 
a "side effect".


    
    

    
  
Comment on attachment 69582 [details] [diff] [review]
Fix

why doesn't this use 0 instead of 1?

        Attachment #69582 -
        Flags: needs-work+

    
    

    
  
cc danm/brendan for reviews (when a new patch is developed)
Summary: There is an extra text box in the link properties box → There is an extra text box in the link properties box; edit fields won't accept caret

    
    

    
  
Right, "0" seems to work fine. I'll use that

    
    

    
  


  
Thanks to Neil for this fix

        Attachment #69582 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 69666 [details] [diff] [review]
Better fix -- need to keep "textbox" in scope

r=cmanske
Fix is by neil@parkwaycc.co.uk

        Attachment #69666 -
        Flags: review+

    
    

    
  
kin prefers setTimeout( function(textbox) { textbox.focus(); }, 0, textbox );

    
    

    
  

      
      
      
      

        Attached patch
          
          
        One more try!
        — 
          — Splinter Review
      

    


  
This "more explicitly passes in the textbox" to the inner function

        Attachment #69666 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 69670 [details] [diff] [review]
One more try!

r=cmanske
again, fix by Neil

        Attachment #69670 -
        Flags: review+

    
    

    
  
Comment on attachment 69670 [details] [diff] [review]
One more try!

sr=kin@netscape.com

        Attachment #69670 -
        Flags: superreview+

    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, 
          
            regression, 
          
            review
Resolution: --- → FIXED
Whiteboard: EDITORBASE+, FIX IN HAND, need r=,sr=

    
    

    
  
Verified on 2002021803.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: