Closed
Bug 1253739
Opened 8 years ago
Closed 8 years ago
incorrect forward-declaration of ShadowLayerForwarder causing build error
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
With some local changes I got a build error because ShadowLayerForwarder is incorrectly forward-declared inside mozilla::layout instead of mozilla::layers, in LayerTransactionChild.h. I'll put up a patch for this shortly.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38335/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38335/
Attachment #8726938 -
Flags: review?(sotaro.ikeda.g)
Comment 2•8 years ago
|
||
Comment on attachment 8726938 [details] MozReview Request: Bug 1253739 - Fix incorrect namespace on forward declaration. r?sotaro https://reviewboard.mozilla.org/r/38335/#review34931 Drive-by r+
Attachment #8726938 -
Flags: review+
Assignee | ||
Comment 3•8 years ago
|
||
Thanks!
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8fd2d0f7ce49
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment 6•8 years ago
|
||
Comment on attachment 8726938 [details] MozReview Request: Bug 1253739 - Fix incorrect namespace on forward declaration. r?sotaro https://reviewboard.mozilla.org/r/38335/#review34967
Attachment #8726938 -
Flags: review?(sotaro.ikeda.g) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•