1254109 - Improved holiday calendars for the Netherlands (2010-2050)

Status: RESOLVED WONTFIX

(Calendar :: Website, enhancement)

Description

[Pander]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160209234513

Steps to reproduce:

Please update the calendars for Dutch Holidays on https://www.mozilla.org/en-US/projects/calendar/holidays/ as I have fixed some small bugs, one of the being an incorrect date. See commit history https://github.com/PanderMusubi/dutch-holidays for details.

The entries that need updating are:
  Netherlands holidays thanks to Pander 	2010-2050
with:
  https://raw.githubusercontent.com/PanderMusubi/dutch-holidays/master/NederlandseFeestdagen.ics
and:
  Netherlands (English) holidays thanks to Pander 	2010-2050
with:
  https://raw.githubusercontent.com/PanderMusubi/dutch-holidays/master/DutchHolidays.ics

Somehow adding a link to https://github.com/PanderMusubi/dutch-holidays on Pander in "thanks to Pander" would be appreciated.

PS   You might want to incorporate this validation before adding or upgrading calendars http://severinghaus.org/projects/icv/ Also possible to run this from a JAR file (if appropriate, please create a bug for that as a reminder). This validator notified me of three bugs. I am sure more calenders would benefit from it. You might even want to run it on all calendars currently offered by Mozilla and notify all maintainers.

Comment 1

[Pander]

I understand the need for backward comparability of links. Hence, I am refactoring of the request. All above can be ignored now. This upgrade is also needed as the calendars itself have been upgraded. By making the following four changed, all Dutch holiday calendars are again up to date and a German version is added. Please do:

1. Update https://www.mozilla.org/media/caldata/DutchHolidays.ics with the content of https://raw.github.com/PanderMusubi/dutch-holidays/master/NederlandseFeestdagen.ics

2. Update https://www.mozilla.org/media/caldata/DutchHolidaysEnglish.ics with the content of https://raw.github.com/PanderMusubi/dutch-holidays/master/DutchHolidays.ics

3. Add next to the two calendars above, one which is called "Netherlands (German) holidays thanks to Pander" as https://www.mozilla.org/media/caldata/DutchHolidaysGerman.ics with the content of https://raw.github.com/PanderMusubi/dutch-holidays/master/NiederlaendischeFeiertage.ics

4. Add link to a link to Pander in each of the three "thanks to Pander" with the url https://github.com/PanderMusubi/dutch-holidays

Thanks for making this update so that people use proper and up to date calendars for holidays in the Netherlands.

Comment 2

[Martin Schröder [:mschroeder]]

Resolving as WONTFIX as holiday calendar updates are handled elsewhere now.

Please contribute your holiday calendar file by using following new process:

Contributing a Holiday Calendar

If you would like to send us your calendar files, please follow these steps:

1. Create a new local calendar, e.g. "$Country$ Holidays".
2. Create the different holidays of your country in this local calendar.
3. Right-click on this calendar and choose "Export Calendar". Please use the iCalendar (ics) format.
4. Create a Pull Request or file an Issue on the website repository (https://github.com/thundernest/thunderbird-website) and attach your holiday file.