1254432 - The long description is cut in Marketplace preview area

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[cindylee]

Attachment: NG.png

[Description]
The long description is cut in Marketplace preview area without scroll bar.

[Test Steps]
1. Launch Apps->Web Apps.
2. Move cursor to focus on an App with long description.
3. Check the preview area.
4. The long description is cut without scroll bar.

[Expected Result]
4. If the description is too long to show, there should be a scroll bar.

[Actual Result]
4. The long description is cut without scroll bar.
Please refer to attachment.

[Note]
This issue is also observed on v2.5.

[Frequency]
5/5

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/4c8fb6271fc5268fcec2054b3eb7bd620cfb6f74
gecko:
https://hg.mozilla.org/mozilla-central/rev/b6acf4d4fc20431a8ae14bf32cdc6e43a9c0f9ad

Comment 1

[Mike Lien[:mlien]]

[Blocking Requested - why for this release]: description has truncation if text too long

Comment 2

[Mike Lien[:mlien]]

Now we have two contents encounter this issue: "kicker" and "YOUZEEK Free Music"

Comment 3

[Evelyn Hung]

Tori, need your input of how to deal with it. Thanks!

Comment 4

[Tori Chen [:tori]]

Helen could you take a look on this?

Comment 5

[Evelyn Hung]

Michael, do you think we can fix this issue by limiting the length of description?

Comment 6

[Helen Huang [:HHuang]]

ni Peko. She is the visual owner for Marketplace now. 

Hi Peko, can you take a look at this bug? Thanks!

Comment 7

[Michael Ellis]

WE do this currently.   It was my understanding that 430 characters was the maximum length for a description.  This is what we have been communicating to partners. The Kicker description is 428 characters, including spaces.  So, they delivered a description matching our ask. 

@Evelyn - Is 430 not the correct number? Has something changed to alter this?

Comment 8

[Peko Chen [:pekochen]]

Hi Joseph
Base one the spec,the size for the description area could be fitted 430 characters (6 rows)
Please keep the preview size according to our discussion.
Moreover, the highlight app icon is too big.
Can you help to fix it?
Thanks~

Comment 9

[Michael Ellis]

@Peko -  I now know we need to keep descriptions to "6 Rows".  Thanks!  This is new information to me;   this will be helpful information for partners to craft a TV listing that both pleases their team and meets our criteria.

Comment 10

[Michael Ellis]

@ Peko - How many Characters can fit on a single row of text?  71? 72? (does it differ by row?)  Please let me know as much information as you are able to share.  This will allow me to help ensure Partners craft listing descriptions that work well with our design.

Comment 11

[Evelyn Hung]

Peko help answer the question. Thanks!
Assign to Joseph per comment 8.

Comment 12

[Peko Chen [:pekochen]]

Hi Michael,

68 Characters can fit on a single row.
Thanks~

Comment 13

[Michael Ellis]

My math is off. Which one of these 3 assumptions is false?

Max = 430 characters
Max = 6 rows
Max = 68 Characters per row. 

But 6 * 68 = 408, so one of these 3 must be wrong.

Comment 14

[Joseph Yeh [:joseph]]

Attachment: jostw:josyeh/Marketplace/master/Bug1254432 > mozilla-b2g:master

Comment 15

[Joseph Yeh [:joseph]]

Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/5149fee3a713cf46b8592a47bff6718668938d91


The dev server did not update due to some building failure. See the follow up bug 1257739.

Comment 16

[Michael Ellis]

@ Peko - Please see comment 13 & provide reply :)

Comment 17

[Peko Chen [:pekochen]]

Hi Michael,

Sorry it's my typo.
Please follow
Max = 6 rows
Max = 68 Characters per row.
it would be 6 * 68 = 408
Thanks