Closed Bug 1254597 Opened 8 years ago Closed 8 years ago

Add Menu button to browser toolbar

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: fluffyemily, Assigned: fluffyemily)

References

Details

Attachments

(2 files)

Pull request
48 bytes, text/x-github-pull-request
jhugman
: review+
tecgirl
: ui-review+
sleroux
: feedback+
Details | Review
Pull Request
48 bytes, text/x-github-pull-request
Details | Review 
We need to display the menu button on the browser toolbar. This will involve:

on iPhone portrait:

* make browser toolbar present on both browser and home panels
* remove bookmark icon from toolbar
* move share icon to bookmark position
* move refresh/stop loading icon to share position
* add menu icon at current refresh/stop loading position

on iPad portrait, iPad landscape & iPhone landscape:

* replace existing bookmark icon with menu icon
* ensure menu enabled even when top sites are displaying
Status: NEW → ASSIGNED
Blocks: 1260124
No longer blocks: 1210109
Attached file Pull request — 

        Attachment #8735892 -
        Flags: ui-review?(randersen)

        Attachment #8735892 -
        Flags: review?(sleroux)

        Attachment #8735892 -
        Flags: review?(jhugman)

    
    

    
  
Comment on attachment 8735892 [details] [review]
Pull request

LGTM! Left some chatter on the PR.

        Attachment #8735892 -
        Flags: review?(sleroux) → review+

    
    

    
  
Comment on attachment 8735892 [details] [review]
Pull request

Sorry! Moving this to feedback+ instead of review+ to resolve the rotation popover issue I mentioned in the PR.

        Attachment #8735892 -
        Flags: review?

        Attachment #8735892 -
        Flags: review+

        Attachment #8735892 -
        Flags: feedback+

    
    

    
  
Comment on attachment 8735892 [details] [review]
Pull request

Looking great to me.

        Attachment #8735892 -
        Flags: review?(jhugman) → review+

        Attachment #8735892 -
        Flags: ui-review?(randersen) → ui-review+

    
    

    
  

      
      
      
      

        Attached file
          
        Pull Request
        — 
      

    


  
This is the merged pull request taken from original that got a tad screwed up with rebasing

    
  
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

        Attachment #8735892 -
        Flags: review?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: