1254657 - Fix issue with sending of Content:LoadURIResult

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[:Gijs (he/him)]

RemoteWebProgress is currently sad because aMessage.json is null. Per discussion with mconley, we should treat the Content:LoadURIResult message specially and avoid the main switch statement for it, and just bail out quickly.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1254657 - change how we send Content:LoadURIResult to avoid upsetting RemoteWebProgress.jsm, r?mconley

Review commit: https://reviewboard.mozilla.org/r/38765/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38765/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8728040 [details]
MozReview Request: Bug 1254657 - change how we send Content:LoadURIResult to avoid upsetting RemoteWebProgress.jsm, r?mconley

https://reviewboard.mozilla.org/r/38765/#review35421

LGTM - well spotted!

::: toolkit/modules/RemoteWebProgress.jsm:187
(Diff revision 1)
> +    if (aMessage.name == "Content:LoadURIResult") {

Maybe add a quick comment here saying that this is intentionally separated from the switch statement because it doesn't need to call any progress listeners, or something along those lines.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/75dbc6dae295

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/75dbc6dae295