1254726 - Intermittent test_action-clear-snapshots_06.js | Test timed out

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=7872601&repo=fx-team



PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | DevToolsUtils.assert threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff
PROCESS | 5211 | @@redux/middleware/task#error threw an exception: Error: Assertion failure: Should be diffing when ending a census diff

Comment 1

[Julian Descottes [:jdescottes]]

Possible race condition if the census diff has not been completed when we attempt to clear all snapshots. 

Now waiting explicitly for the TAKE_CENSUS_DIFF_END action before continuing the test.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6911b8385660

Comment 2

[Julian Descottes [:jdescottes]]

Not sure how to trigger OSX 10.6 tests on try. Don't think my previous push will run anything.

Another try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9600858136d4

Comment 3

[Ryan VanderMeulen [:RyanVM]]

On trychooser, there's a "Restrict tests to platform" section where you can choose 10.6. You can also add jobs to an existing push from Treeherder via the dropdown on the right hand side - "add new jobs".

Comment 4

[Julian Descottes [:jdescottes]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

Thanks for the tips!

> On trychooser, there's a "Restrict tests to platform" section where you can
> choose 10.6. 

That's how I built my query for the 2nd job. But I still was unsure about it. After checking 10.6 you still have to select a platform and I checked macosx64, randomly. 

> You can also add jobs to an existing push from Treeherder via
> the dropdown on the right hand side - "add new jobs".

Actually did it with the first job. Since new jobs take a long time to appear, I thought it didn't work.

Just relaunched a few XPC shell tests in the second try push 
: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6911b8385660

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: MozReview Request: Bug 1254726 - fix intermittent test_action-clear-snapshots_06 (osx10.6);r=fitzgen

After enabling diff view and selecting two snapshots, wait for TAKE_CENSUS_DIFF_END
action in the test before deleting all snapshots. Otherwise, TAKE_CENSUS_DIFF_END
might be dispatched after clearSnapshots toggled diff mode off.

Review commit: https://reviewboard.mozilla.org/r/39451/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39451/

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8729455 [details]
MozReview Request: Bug 1254726 - fix intermittent test_action-clear-snapshots_06 (osx10.6);r=fitzgen

https://reviewboard.mozilla.org/r/39451/#review36157

::: devtools/client/memory/test/unit/test_action-clear-snapshots_06.js:47
(Diff revision 1)
> +
>    ok(getState().diffing, "We should be in diffing view");
>  
> +  yield waitUntilAction(store, actions.TAKE_CENSUS_DIFF_END);
> +  ok(true, "Received TAKE_CENSUS_DIFF_END action");
> +

Thanks! I should have caught this in the initial review :(

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5fecb1030237

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fecb1030237

Comment 9

[Intermittent Failures Robot]

10 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6
* fx-team: 3
* mozilla-central: 1

Platform breakdown:
* osx-10-6: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1254726&startday=2016-03-07&endday=2016-03-13&tree=all