Closed
Bug 1255178
Opened 8 years ago
Closed 8 years ago
Minor cleanups in test_wheel_default_action.html
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(2 files)
|
1.56 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
|
4.05 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
I noticed a few minor issues while looking at this test. I also wrote a few refactorings to make it easier to what is understanding with the asynchrony, but I don't know if it is worth landing those, so I'll skip them for now.
|
Assignee | |
Comment 1•8 years ago
|
||
Also, remove some trailing whitespace. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed14a344e2b2
Attachment #8728705 -
Flags: review?(masayuki)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Bug 1140293 changed hitEventLoop calls to sendWheelAndWait but did not remove the extra argument.
Attachment #8728706 -
Flags: review?(masayuki)
|
||
Updated•8 years ago
|
Attachment #8728705 -
Flags: review?(masayuki) → review+
|
|
||
Updated•8 years ago
|
Attachment #8728706 -
Flags: review?(masayuki) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/3557a7a3736b https://hg.mozilla.org/integration/mozilla-inbound/rev/22cbefa8f1d2
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3557a7a3736b https://hg.mozilla.org/mozilla-central/rev/22cbefa8f1d2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•