Closed
Bug 1255185
Opened 8 years ago
Closed 8 years ago
Move --with-external-source-dir to moz.configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38997/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38997/
Attachment #8728633 -
Flags: review?(cmanchester)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8728633 [details] MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38997/diff/1-2/
Comment 3•8 years ago
|
||
Comment on attachment 8728633 [details] MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure https://reviewboard.mozilla.org/r/38997/#review35705 ::: old-configure.in (Diff revision 2) > - if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then > - AC_MSG_RESULT([none]) > - AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).]) > - else > - AC_MSG_RESULT([$MOZ_BUILD_APP]) > - fi I see we didn't port this check... is it obsolete?
Attachment #8728633 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #3) > Comment on attachment 8728633 [details] > MozReview Request: Bug 1255185 - Move --with-external-source-dir to > moz.configure > > https://reviewboard.mozilla.org/r/38997/#review35705 > > ::: old-configure.in > (Diff revision 2) > > - if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then > > - AC_MSG_RESULT([none]) > > - AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).]) > > - else > > - AC_MSG_RESULT([$MOZ_BUILD_APP]) > > - fi > > I see we didn't port this check... is it obsolete? It's covered by requiring a moz.configure file existing in the same directory.
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a959b172be4c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•