Closed
Bug 1255404
Opened 8 years ago
Closed 7 years ago
handling.properties shouldn't be an override over toolkit's one, and possibly merge
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: Pike, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/source/mobile/android/locales/jar.mn#82 pretends that chrome://browser/locale/handling.properties would be a substitute for chrome://mozapps/locale/handling/handling.properties. But they have nothing to do with each other, comparing https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/handling/handling.properties and https://dxr.mozilla.org/mozilla-central/source/mobile/android/locales/en-US/chrome/handling.properties. The only string in the mobile one is used in https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/HelperAppDialog.js#200, and maybe we just merge this into browser.properties? Also, do we need the toolkit handling.properties? If so, we should use the proper toolkit forwarding for that.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8901622 -
Flags: review?(l10n) → feedback?(l10n)
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8901622 [details] Bug 1255404 - detangle handling.properties in android. https://reviewboard.mozilla.org/r/173014/#review178514
Attachment #8901622 -
Flags: review+
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8901622 [details] Bug 1255404 - detangle handling.properties in android. Not sure why you turned this from a review to a feedback request. Also, not sure if this needs an explicit review by a peer from the mobile team.
Attachment #8901622 -
Flags: feedback?(l10n)
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8901622 [details] Bug 1255404 - detangle handling.properties in android. Only because I didn't get to finish manual testing before I was going to sleep. It all looks good now. Asking then for addl. r? from :rnewman's (who added the file I'm removing).
Attachment #8901622 -
Flags: review?(rnewman)
Comment 5•7 years ago
|
||
Looks like most of the handling code, and the other strings in that file, changed in https://hg.mozilla.org/mozilla-central/rev/9bae6f3fdfb2
Comment 6•7 years ago
|
||
Comment on attachment 8901622 [details] Bug 1255404 - detangle handling.properties in android. Fine by me.
Attachment #8901622 -
Flags: review?(rnewman) → review+
Pushed by zbraniecki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f89f3519cc7e detangle handling.properties in android. r=Pike
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f89f3519cc7e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•