1255518 - Firefox download buttons: drop support for OS X 10.6-10.8 in August 2016

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Kohei Yoshino [:kohei]]

See https://groups.google.com/d/topic/firefox-dev/f0LNGDmC3KA/discussion

Update the browser detection to show the unsupported system message. 

> The final timeframe for this deprecation has not been finalized,
> but the current proposal is to remove support in Firefox 46.

Comment 1

[Kohei Yoshino [:kohei]]

The discussion is now inactive. Closing this for now.

Comment 2

[Kohei Yoshino [:kohei]]

And they suddenly posted this: https://blog.mozilla.org/futurereleases/2016/04/29/update-on-firefox-support-for-os-x/

Comment 4

[Benjamin Smedberg]

This change needs to be made immediately for nightly.mozilla.org and similar pages, and progressively rolled out to other channels as uplifts to 49 occur.

Comment 5

[Kohei Yoshino [:kohei]]

Will reopen 1270220 to use it for nightly.m.o :)

Comment 6

[Benjamin Smedberg]

Here is the link to use for MacOS deprecation: Here's a link you can use on www.mozilla.org: https://support.mozilla.org/kb/firefox-osx

Comment 7

[Benjamin Smedberg]

Kohei, this rides to aurora next week. Will this be ready for devedition rollout then?

Liz, I think you're 49 RM? Heads-up that this may affect normal merge-day rollout plans.

Comment 8

[Kohei Yoshino [:kohei]]

I'll send a pull request for this later today or tomorrow.

Comment 9

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d6574667fc83e7a1ddb73a1573b45a6f06a1cbb2
Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8 in August 2016

https://github.com/mozilla/bedrock/commit/1ddecf9a67f37462f2e077c40f6b481ed2ebff1f
Merge pull request #4174 from kyoshino/bug-1255518-pre-mavericks

Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8 in August 2016

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/014fcfe6cd8220adb1c67393543090e522c29f7f
Revert "Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8 in August 2016"

https://github.com/mozilla/bedrock/commit/0174239f580190b6f11472420c4dfcbbea52b939
Merge pull request #4179 from mozilla/revert-4174-bug-1255518-pre-mavericks

Revert "Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8 in August 2016"

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Hi Kohei, thanks for the commit.  Is this resolved now?
I will also add it to the release notes that we are dropping support, for aurora 49.

Comment 13

[Benjamin Smedberg]

I believe/hope that the commits here were for devedition only. This bug needs to stay open through the 49 cycle so we can make the same change for beta and release at the appropriate uplift point.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

OK. Thanks. I will leave it tracked and affected for 49, but no longer a blocker. It seems fairly trivial to put into place now; we just have to remember to do it at the right point in time.

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/04103f5050ace322aa4190b4c42e0c4c8c8c8966
Fix Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8, take 2

https://github.com/mozilla/bedrock/commit/2f3642ea5c28043d94f1e1d5f035174a5863181a
Merge pull request #4180 from kyoshino/bug-1255518-pre-mavericks

Fix Bug 1255518 - Firefox download buttons: drop support for OS X 10.6-10.8, take 2

Comment 16

[Benjamin Smedberg]

Kohei was this closed prematurely by the robot? Still work to do for beta and release, right?

Comment 17

[Kohei Yoshino [:kohei]]

The bot closed the bug as my pull request has reviewed and committed to master. We still have to push the change to production. The change is 49 only, so Beta & Release should not be affected.

Comment 18

[Kohei Yoshino [:kohei]]

I meant 49 *and above*.

Comment 19

[Kohei Yoshino [:kohei]]

The change is live now.

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Andrei, can your team check that this is working as intended for 49 beta? Thanks. 

Marking this as a release blocker since I think we still will have work to do on production for 49 release. Kohei is that correct?

Comment 21

[Andrei Vaida [:avaida]]

I can confirm that the behavior on Aurora 50 and Beta 49 is correct. I'm not quite
sure about Nightly 51 though, Kohei, Liz -- could you please confirm?

Here's a breakdown:
  - beta.mozilla.org
    - there's no download button available
    - the following message is displayed instead: "Your system
      doesn't meet the requirements to run Firefox."
    - "requirements" points to https://support.mozilla.org/kb/firefox-osx
  - aurora.mozilla.org
   - there's no download button available
    - the following message is displayed instead: "Your system
      doesn't meet the requirements to run Firefox."
    - "requirements" points to https://support.mozilla.org/kb/firefox-osx
  - nightly.mozilla.org
    - a download button is available with the label: "Mac (OS X
      10.9+)"
    - since the download button is not disabled, the build can be downloaded

Comment 22

[Kohei Yoshino [:kohei]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #20)
> Marking this as a release blocker since I think we still will have work to
> do on production for 49 release. Kohei is that correct?

The change is already on production. How to test:

1. Go to https://www.mozilla.org/en-US/firefox/channel/ using a legacy OS X system (or just spoof the browser's user agent string)
2. Make sure the Beta and Developer Edition download buttons are disabled with a label, say, " Your system doesn't meet the requirements to run Firefox."

Comment 23

[Kohei Yoshino [:kohei]]

Oh I missed Andrei's comment 21. Yes, those results are correct.

Comment 24

[Kohei Yoshino [:kohei]]

And speaking of nightly.mozilla.org, we don't have any platform detection on that page so the download button is not disabled even on unsupported platforms, as Andrei explained. Since nightly.mozilla.org has been deprecated (Bug 717322), I think that's fine.

Comment 25

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks very much, sounds like we can count this fixed for 49 then. I appreciate the extra QA!

Comment 26

[Andrei Vaida [:avaida]]

Kohei - great, thank you for following up!

Liz - I'm gonna go ahead and set the 49 flag to verified, feel free to ni? me if there's anything else I can help with here.