1255989 - Cannot drag window from empty space in bookmarks toolbar items when customized to the menubar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Avi Halachmi (:avih)]

First noticed this on first Aurora 47 build on Windows (47.0a2 (2016-03-11)) where I couldn't drag an addon (DownThemAll) window.

Then I noticed I can't drag the Firefox window itself too.

Tried nightly and it did drag.

Then I customized Nightly it as follows:
1. burger -> customize
2. Show/Hide tooblars -> [check] menu bar
3. Show/Hide toolbars -> [check] bookmarks toolbar
4. Drag the bookmark toolbar (which just became visible) to the right side of the menu toolbar (which also just became visible).
5. Exit customize.

6. Try dragging the Firefox from the top of the window (right side of the bookmarks toolbar).

Expected: Firefox window follows the mouse.

Actual: Firefox window doesn't get dragged.

Mozregression pointed to this range:
15:52.78 INFO: Last good revision: be27e36ce427df475b3ff827d8c0258c1c34c5b5
15:52.78 INFO: First bad revision: a67a25a5af7446d8ae9beb453bcfa12be368fcef

Which point to bug 1241275 and bug 1219215, both seem highly relevant.

P.S.
Didn't follow up on the "cannot drag addon window" symptom, but I'm guessing that fixing the reported issue would also fix the addon symptom. I'll report back on this once a fix lands.

Comment 1

[Avi Halachmi (:avih)]

For reference, also from the same run of mozregression:

15:52.78 INFO: Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=be27e36ce427df475b3ff827d8c0258c1c34c5b5&tochange=a67a25a5af7446d8ae9beb453bcfa12be368fcef

Comment 2

[Avi Halachmi (:avih)]

Attachment: DownThemAll-win.png

Screenshot of the DownThemAll addon window which cannot be dragged too. No menu, but it does have icons to the left of the the drag-area (which did drag correctly on Aurora 46).

Comment 3

[Avi Halachmi (:avih)]

Also, not sure if it's the same bug, but it appears that the same area which cannot be used for drag, also doesn't respond to double-click to toggle window maximize/restore.

Comment 4

[:Gijs (he/him)]

This is fixable with some CSS, which should be fairly trivial to infer from bug 1219215. I don't have time to work on it myself right now.

Comment 5

[Avi Halachmi (:avih)]

Adding that on IRC Gijs mentioned that he doesn't intend to address this.

> <Gijs> I think it can be fixed, I don't intend to fix it myself

This is really annoying to whoever is affected by it. My workaround for now is to install a theme, after which drag (or double click) works again at the empty areas of the titlebar. Unfortunately this has other issues, like that it doesn't change color when the window become inactive or the mere fact that a theme has to be installed to fix an issue with Firefox. So overal it's got a great solution IMO.

Comment 6

[:Gijs (he/him)]

This can be addressed by adding a selector to this block:

https://dxr.mozilla.org/mozilla-central/rev/6adc822f5e27a55551faeb6c47a9bd8b0859a23b/browser/base/content/browser.css#373-381

that makes the personal-bookmarks item draggable when it is in the tabstoolbar or menubar on Windows (even when no lwtheme is present).

It might also need to adjust the devedition styling if necessary - I haven't thought about it in detail.

Comment 7

[Avi Halachmi (:avih)]

Thanks for the reference.

I was able to make it work locally by adding the following to <profile>/chrome/userChrome.css:

/* Allow window drag when the bookmarks toolbar is at the titlebar.
 * based on https://bugzilla.mozilla.org/show_bug.cgi?id=1255989#c6
 */
#main-window[tabsintitlebar]:not([customizing]) #personal-bookmarks {
  -moz-window-dragging: drag;
}

I'll post here if I notice any issues with this. I'm guessing there won't be issues since I've been using a theme in the past few weeks which makes it behave like this as far as I understand (from the reference at comment 6), and it's been working well with the theme.

Why is there a difference when using or not using a theme to begin with in this regard?

Comment 8

[uncajesse]

Version 47.0 released to public channel on June 7th, and Default 47.0 theme updated on June 9th and now I'm experiencing this bug too. I've found I can drag the window from a very small space just to the left of the minimize button, in Windows 7 with Aero enabled.

Comment 9

[Justin Dolske [:Dolske]]

Dao: you could pick this up?

Comment 10

[Dão Gottwald [:dao]]

Attachment: patch

Comment 11

[:Gijs (he/him)]

Comment on attachment 8765918 [details] [diff] [review]
patch

>diff --git a/browser/base/content/browser.css b/browser/base/content/browser.css
>--- a/browser/base/content/browser.css
>+++ b/browser/base/content/browser.css
>@@ -238,16 +238,20 @@ toolbar[customizing] > .overflow-button 
> #main-window[tabsintitlebar] #titlebar-buttonbox {
>   position: relative;
> }
> 
> #titlebar-buttonbox {
>   -moz-appearance: -moz-window-button-box;
> }
> 
>+#personal-bookmarks {
>+  -moz-window-dragging: inherit;
>+}
>+

Nit: I'd sooner put this^ here:

>-/* Ensure that empty parts of the bookmarks container can be dragged on OSX, and on other OSes
>- * only when a lwtheme is in use. */
>-%ifdef XP_MACOSX
>-#main-window[tabsintitlebar]:not([customizing]) #personal-bookmarks {
>-%else
>-#main-window[tabsintitlebar]:not([customizing]) #personal-bookmarks:-moz-lwtheme {
>-%endif
>-  -moz-window-dragging: drag;
>-}

instead, rather than in the middle of the titlebar stuff.

Comment 12

[Dão Gottwald [:dao]]

I put it intentionally there, since it currently only makes sense in the CAN_DRAW_IN_TITLEBAR case. I.e. it's useless on Linux.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/abdc1a4e7080
Bookmarks toolbar items should inherit -moz-window-dragging from the parent toolbar. r=gijs

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/abdc1a4e7080

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 8729826 [details]
DownThemAll-win.png

If there's still a regression specifically for DownThemAll, please file that separately, assuming this is our fault (might make sense to contact the add-on author first).

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 8765918 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1219215
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: no test coverage
[Risks and why]: fairly isolated CSS-only fix, low risk
[String/UUID change made/needed]: none

Comment 17

[Avi Halachmi (:avih)]

Bookmarks toolbar - confirmed dragging and double click now work in firefox nightly (without any userChrome.css) - at the same use cases where they were broken previously.

(In reply to Dão Gottwald [:dao] from comment #15)
> If there's still a regression specifically for DownThemAll, please file that
> separately, assuming this is our fault (might make sense to contact the
> add-on author first).

FYI WRT DownThemAll - not fixed so far, but the issue only manifests with their beta/nightly builds (where they use toolbars, while the earlier release version uses a normal window instead). The screenshot I posted was using such nightly build of DownThemAll.

With DownThemAll - I don't know if it's a Firefox issue or not, and I didn't search for a regression window with it, but as far as I can tell it did stop working around the same time when the bookmark toolbar drag issue was introduced.

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8765918 [details] [diff] [review]
patch

Review of attachment 8765918 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes a regression. Take it in 48 beta 6 and aurora.

Comment 19

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-aurora/rev/128eff0a581f

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ebaf4086c18c2d1e3f0af12ade55840413342bc3

Comment 21

[Cipri]

I reproduced the issue on Aurora beta 47.0a2 (2016-03-11) using Windows 10 x64, Ubuntu 14.04
I verified that the issue is fixed on Firefox 48 (beta 5) 49 (latest aurora) 50 (latest nightly) running Windows 10 x64, Ubuntu 14.04 x32.

After I changed the theme from "Customize" I noticed that you can't drag window from empty space in bookmarks toolbar. Should I log a bug on this?

Comment 22

[:Gijs (he/him)]

(In reply to Cipri from comment #21)
> I reproduced the issue on Aurora beta 47.0a2 (2016-03-11) using Windows 10
> x64, Ubuntu 14.04
> I verified that the issue is fixed on Firefox 48 (beta 5) 49 (latest aurora)
> 50 (latest nightly) running Windows 10 x64, Ubuntu 14.04 x32.
> 
> After I changed the theme from "Customize" I noticed that you can't drag
> window from empty space in bookmarks toolbar. Should I log a bug on this?

Which theme are you testing with? It's expected that the area isn't draggable in the default and the developer/devedition theme. Otherwise it should be draggable (and it is for me, on 48b5 on win10).

Comment 23

[Cipri]

Yes you are right on 48b5 running windows 10.
The problem is on Ubuntu 14.04 x32. I can't drag the window with a customize theme,(like Space Fantasy) only with default theme. It is normal ?

Comment 24

[Dão Gottwald [:dao]]

Yes, that's expected since we don't draw lightweight themes in the title bar on Linux.

Comment 25

[:Gijs (he/him)]

Marking verified based on comment #21 and later.