1256184 - Remove magical Talos g2 enabling code that isn't needed anymore

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

mozilla-tests/config.py has a block of code for enabling Talos g2 unconditionally on Gecko 40+. At this point, all Talos-running branches are already newer than version 40, so this block is at best a no-op and at worst actually causes Talos jobs to be scheduled on branches that otherwise wouldn't run any Talos tests.

That's actually how I found this bug - I'm working on getting Ash ready for e10s testing and was finding that g2 was somehow getting enabled even though I was explicitly setting "'enable_talos': False" in project_branches.py.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch

Looks like Oak was special too :)

Builders removed
- Rev7 MacOSX Yosemite 10.10.5 oak talos g2
- Ubuntu HW 12.04 x64 oak pgo talos g2
- Ubuntu HW 12.04 x64 oak talos g2
- Windows 7 32-bit oak pgo talos g2
- Windows 7 32-bit oak talos g2
- Windows 8 64-bit oak pgo talos g2
- Windows 8 64-bit oak talos g2
- Windows XP 32-bit oak pgo talos g2
- Windows XP 32-bit oak talos g2

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch

Whoops, attached the test patch instead of the actual one.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8730031 [details] [diff] [review]
patch

Review of attachment 8730031 [details] [diff] [review]:
-----------------------------------------------------------------

good find.  I think we could clean up another 500 lines in that file if we were so inclined :)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8730031 [details] [diff] [review]
patch

http://hg.mozilla.org/build/buildbot-configs/rev/ec3937ad8bd7

Comment 5

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/ec3937ad8bd7