1256327 - Much too easy to delete tasks or events irreversibly

Status: RESOLVED DUPLICATE of bug 1428254

(Calendar :: Tasks, defect)

Description

[xracoonx]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160210153822

Steps to reproduce:

Delete a task


Actual results:

The task was without further question irreversibly deleted


Expected results:

Since the task is deleted irreversibly there should be a dialog warning of the irreversible deletion

Comment 1

[[:MakeMyDay]]

Confirming. We have an inconsitent behaviour here. If deleting an item from the calendar/task view, there's no confirmation dialog, while deleting from within the event/task dialog when editing an existing item triggers a popup to confirm deletion.

Both ways should trigger the popup, however we probably should add a checkbox to opt-out from further confirmations (also an according UI visible preference would be nice, then).

Apart from that, the delete button in the event dialog is working in fact as a cancel button when creating an event/task, which feels wrong. Maybe its better to display the button only when editing an existing event.

Comment 2

[65719283]

Totally agree with this. Along these lines, the option to undo a "delete" would also be nice. After deleting a calendar event, "Undo" is greyed out on the edit menu, making the deletion permanent, very frustrating if the delete was accidental.

Comment 5

[vlakoff]

Couldn't agree more with this. Just pressing "delete", the event is deleted without any prompt, and there is no "undo"... While the current situation is incredibly dangerous, simply adding the confirmation box should be relatively easy?

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to [:MakeMyDay] from comment #1)
> Both ways should trigger the popup, however we probably should add a
> checkbox to opt-out from further confirmations (also an according UI visible
> preference would be nice, then).
I don't agree with the popup, but then again that is up to UX to decide. I'm just not a fan of popups because they interrupt workflows. We should have a functioning undo/redo system, and if that doesn't work then that is a bug we definitely need to fix.

> 
> Apart from that, the delete button in the event dialog is working in fact as
> a cancel button when creating an event/task, which feels wrong. Maybe its
> better to display the button only when editing an existing event.
A matter of perspective :) If you create a new event, then hit save (but don't close), then "Delete" is accurate. Even though technically we haven't created the event when first opening the dialog, for the user it won't make much of a difference, the thing you are editing will go away when you click delete. If we go with anything else we either have to make the delete button magically appear when "Save" is clicked, or we have to switch labels on the button on the fly.

Comment 7

[Victor]

Faced this today and found it a very unpleasant behavior. I think I can submit a patch to display the confirmation box before deleting the task (like the task dialog does). Are there any objections or things I need to know about?

Comment 8

[Lasana Murray]

I'm closing this as bug 1337356 landed and it should address this issue sufficiently.

Comment 9

[vlakoff]

Let me, kindly, disagree about closing this ticket.

Although there will be the long awaited undo/redo ability, I still think there should be a deletion prompt. Deleting an event or a task is a significant action, which is worth a prompt. Better than hitting Delete by mistake, without noticing it, thus not undoing it...

Ah, and I have looked at the undo/redo patch. That's a very impressive work, so, many thanks!

Comment 10

[Thomas D. (:thomas8)]

(In reply to Lasana Murray from comment #8)

I'm closing this as bug 1337356 landed and it should address this issue sufficiently.

*** This bug has been marked as a duplicate of bug 1337356 ***

Lasana's awesome work in bug 1337356 covers the worst of this bug by providing ux-error-recovery.
However, the ux-error-prevention part has not yet been addressed (as pointed out by many users here and elsewhere), and ironically, we'll warn where there's no risk (deleting single event from inside event edit dialog), but not warn where there is risk (deleting 10 selected events).
Undo won't help for those scenarios of accidental deletion, either totally unintended, or erroneous assumptions about the current focus and/or selection.