Closed
Bug 1256774
Opened 8 years ago
Closed 7 years ago
[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_bug_638949_copy_link_location.js
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: linclark, Unassigned, Mentored, NeedInfo)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(1 file)
1.18 KB,
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards Then you can see the issues that need to be fixed by running > eslint --no-ignore devtools/client/webconsole/test/browser_bug_638949_copy_link_location.js
Reporter | ||
Updated•8 years ago
|
Whiteboard: [btpp-backlog]
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8739372 [details] [diff] [review] 1256774.patch Review of attachment 8739372 [details] [diff] [review]: ----------------------------------------------------------------- This one looks good to. Feel free to add the checkin-needed keyword
Attachment #8739372 -
Flags: review?(jlaster) → review+
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(lclark)
Updated•8 years ago
|
Assignee: nobody → bmanojkumar24
Status: NEW → ASSIGNED
Comment 5•8 years ago
|
||
When I test this out with the patch applied, I'm still seeing some eslint errors: 29:3 error content is a possible Cross Process Object Wrapper (CPOW) mozilla/no-cpows-in-tests 45:3 error 'goUpdateCommand' is not defined no-undef 50:9 error 'waitForContextMenu' is not defined no-undef 57:3 error content is a possible Cross Process Object Wrapper (CPOW) mozilla/no-cpows-in-tests 75:3 error 'goUpdateCommand' is not defined no-undef 80:18 error 'promise' is not defined no-undef 85:5 error 'goDoCommand' is not defined no-undef 96:9 error 'waitForContextMenu' is not defined no-undef Can you please take a look? This is when running: ./mach eslint --no-ignore devtools/client/webconsole/test/browser_bug_638949_copy_link_location.js For the no-cpows-in-tests issue you'll need to wrap any calls to content inside a ContentTask.spawn, i.e. ContentTask.spawn(gBrowser.selectedBrowser, {}, function* () { content.console.log("bug 638949"); });
Flags: needinfo?(bmanojkumar24)
Updated•7 years ago
|
Blocks: devtools-eslint
Updated•7 years ago
|
Assignee: bmanojkumar24 → nobody
Status: ASSIGNED → NEW
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•