125747 - [FTP] FTP module search-output is ugly

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, defect)

Description

[Hixie (not reading bugmail)]

<Hixie> botbot: ftp gcc
<botbot> Files matching re:gcc [gmt] embed-gcc30-i686-pc-linux-gnu.tar.gz
[2002-2-14 19:51:13]mozilla-gcc30-i686-pc-linux-gnu.tar.gz [2002-2-14 19:51:8]
time now: 19:48:10


Problems: "13]mo", "2002-2-14 19:51:8"
              ^          ^          ^
            space        zero padding

Comment 1

[Hixie (not reading bugmail)]

This is actually still timeless' code, untouched from the techbot days.

I don't understand what it's trying to do. Reassigning to timeless.

Comment 2

[timeless]

the problem is that there are two paths, one uses a pretty print, and one 
doesn't. I'll provide a new file and hixie will test.

Comment 3

[Hixie (not reading bugmail)]

timeless: What's the status of this? If you don't know when you'll get to it, I
recommend moving it to Future so that I don't ask you after each milestone. :-)

Comment 4

[Tanner M. Young [:tmyoung]]

Attachment: Changes to FTP.bm for correct FTP file modification time output

After the discussion in #mozwebtools, I have uploaded the patch that consistently outputted the correct time.  The change may not be the most elegant implementation, but it does cleanly create the wanted functionality.

Comment 5

[Teemu Mannermaa (:wicked)]

Comment on attachment 379393 [details] [diff] [review]
Changes to FTP.bm for correct FTP file modification time output

I doubt you want yourself to review this so let's ask Wolf instead.. :)

Comment 6

[Wolf [:wolf]]

Comment on attachment 379393 [details] [diff] [review]
Changes to FTP.bm for correct FTP file modification time output

Can I get a before/after example here?

Comment 7

[Tanner M. Young [:tmyoung]]

Before:

Files matching re:\. [gmt] mozilla-i686-pc-linux-gnu-gtk2+xft.tar.gz [2005-6-28 21:2:32]mozilla-source.tar.bz2 [2006-2-23 15:48:11]mozilla-win32-stub-installer.exe [2005-7-2 13:48:24]mozilla-source.tar.gz [2006-2-23 15:49:43]mozilla-i586-pc-msvc.zip

After:

Files matching re:\. [gmt] mozilla-i686-pc-linux-gnu-gtk2+xft.tar.gz [2005-06-28 21:02:32] mozilla-source.tar.bz2 [2006-02-23 15:48:11] mozilla-win32-stub-installer.exe [2005-07-02 13:48:24] mozilla-source.tar.gz [2006-02-23 15:49:43]

Comment 8

[Wolf [:wolf]]

Checking in BotModules/FTP.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/FTP.bm,v  <--  FTP.bm
new revision: 2.3; previous revision: 2.2
done

Comment 9

[Tanner M. Young [:tmyoung]]

Dare I verify a bug assigned to me ;).

Verified Fixed.