Closed
Bug 1257581
Opened 8 years ago
Closed 8 years ago
Intermittent test_chrome_ext_downloads_misc.html | Cleanup function threw exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: setup/< :
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(Not tracked)
People
(Reporter: KWierso, Assigned: aswan)
Details
(Keywords: intermittent-failure, Whiteboard: [downloads])
Attachments
(1 file)
Updated•8 years ago
|
Flags: needinfo?(aswan)
Reporter | ||
Comment 1•8 years ago
|
||
These happened shortly after bug 1245641 landed, dunno if that's related.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 4•8 years ago
|
||
This is causing way too many failures. I'm going to disable these tests until this is fixed.
Severity: normal → critical
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5fca7a4520b8363e1feaf92c12470b0dacaf606c Bug 1257581: Disable test_chrome_ext_downloads_misc.html until intermittents are fixed. r=me
Updated•8 years ago
|
Keywords: leave-open
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5fca7a4520b8
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(aswan)
Whiteboard: [downloads]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 8•8 years ago
|
||
Ah, the erase() test carelessly does not wait for downloads to complete. This will be easy to fix once the test changes in the patch for 1245651 have landed.
Assignee: nobody → aswan
Iteration: --- → 48.2 - Apr 4
Assignee | ||
Comment 9•8 years ago
|
||
The original problem was that the erase() test did not wait for downloads to complete which caused a race with cleanup code trying to remove the download directory while downloads were still writing to it. This was fixed in https://hg.mozilla.org/mozilla-central/rev/d6d9e7411319 But meanwhile, the removeFile() test bit-rotted slightly, fixed it here and re-enabled the misc test. Review commit: https://reviewboard.mozilla.org/r/42833/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42833/
Attachment #8735536 -
Flags: review?(kmaglione+bmo)
Assignee | ||
Comment 10•8 years ago
|
||
We've got green on all platforms and 5 good tests on windows (marred by an unrelated devtools failure): https://treeherder.mozilla.org/#/jobs?repo=try&revision=e146c1d15d5f (windows was where all the intermittent failures happened previously, see comment 2 and comment 3)
Comment 11•8 years ago
|
||
Comment on attachment 8735536 [details] MozReview Request: Bug 1257581 Fix and re-enable downloads misc tests r?kmag https://reviewboard.mozilla.org/r/42833/#review39303
Attachment #8735536 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: leave-open → checkin-needed
Comment 12•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3df6a745a563
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3df6a745a563
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Updated•6 years ago
|
status-firefox48:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•