Closed
Bug 1257622
Opened 8 years ago
Closed 8 years ago
Fix search-suggestions.js
Categories
(developer.mozilla.org Graveyard :: Code Cleanup, defect)
developer.mozilla.org Graveyard
Code Cleanup
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: robhudson, Assigned: robhudson)
References
Details
This file has a lot of issues and a simple edit breaks the file in weird ways resulting in either a truncated file or extra hidden characters being added, both of which break the browser from loading the file and parsing it successfully. The goal of this bug is clean up the following: * Fix the weird hidden characters in this file * Fix any jshint errors * General syntax clean up * Attempt to get rid of the unicode normalization [1] * Change the file mode to rw- from rwx [1] I'm not sure unicode normalization is needed here. The search filter groups and filters both use slugs which have no special characters and are not translated.
Comment 1•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/773080bb8659b9bc4c4867ba4788d7df9fd5aaec Fix bug 1257622 - Refactor search-suggestions.js This removes the unicode characters in place of their escape sequences as the unicode was affecting some editors. This also fixes all jshint errors and applies general js syntax reformatting. https://github.com/mozilla/kuma/commit/a93024a91a228333f83a41d0b5e1c9c5dff46a81 Merge pull request #3817 from robhudson/1257622-search-suggestions.js Fix bug 1257622 - Refactor search-suggestions.js
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•