1257981 - mark the root of the rule tree during rule tree GC

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I was just looking at some style system crashes, and one thing that occurred to me is that we should probably mark the root of the rule tree just in case there are (somehow!?) no style contexts.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Mark the root of the rule tree during rule tree GC

MozReview-Commit-ID: 1riBGYsGspn

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So this was fixed on trunk by bug 1258017, but I'd still like to land it on aurora.  (Although the cause of the crashes we see is probably the other problems bholley fixed rather than this one, but it still seems worth trying.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8732390 [details] [diff] [review]
Mark the root of the rule tree during rule tree GC

Approval Request Comment
[Feature/regressing bug #]: not sure; pretty old
[User impact if declined]: potential crash
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low risk; fixes one possible (although probably unlikely) source of crashes
[String/UUID change made/needed]: no

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Though probably we should just backport all of bug 1258017, and not bother with this.  But I should wait to see if Bobby, and release management, agrees...)

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I'll recheck again next week because of bug 1258017 comment 39. Will decide then whether we need both fixes or just one.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello DBaron, do we still need to uplift this fix? I already uplifted the patches from bug 1258017 in Aurora47.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8732390 [details] [diff] [review]
Mark the root of the rule tree during rule tree GC

No need anymore.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) from comment #7)
> Comment on attachment 8732390 [details] [diff] [review]
> Mark the root of the rule tree during rule tree GC
> 
> No need anymore.

Great! Thanks. :)