125921 - Shouldn't have column picker in "Form Manager" dialogs (Forms Never Previewed/Forms Never Saved)

Status: RESOLVED WORKSFORME

(Toolkit :: Form Manager, defect, P4)

Description

[Henrik Gemal]

We shouldn't have the column picker in "Form Manager" dialogs (Forms Never 
Previewed/Forms Never Saved). It's the dialog that gets shown when you select 
Tasks -> Privacy & Security -> Form Manager -> Manage Sites.

It makes no sense to have a column picker since there's only one column.

For a fix please see bug 120257 which was a bug about the same thing.
Basicly just add hidecolumnpicker="true"

the same goes for the Manage Sites dialogs in the Image Manager and Cookie 
Manager. Should I file seperate bugs about that?

20020213

Comment 1

[Stephen P. Morse]

Good suggestion.  And thanks for the reference of how to fix it up.

This is the same problem in the other dialogs you mention as well.  Since I 
own all of them, I'll handle them all at the same time so don't bother filling 
separate bugs.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

This is a trivial thing to fix, please see this patch for sample:
http://bugzilla.mozilla.org/attachment.cgi?id=65514&action=view

Comment 3

[Andreas Kunz]

Attachment: patch

Does the same that was done in the preferences dialog at some point of time:
move the "Category" description from the column header to above the column.

Comment 4

[Andreas Kunz]

Comment on attachment 139672 [details] [diff] [review]
patch

Requesting review from mvl.

I'm not 100% sure if you are an appropriate reviewer for this, but trying
doesn't cost a thing...

Comment 5

[Andreas Kunz]

Ha! I misread this bug! I'll extend the patch to that other dialog ("Manage
Sites")...
Or is that one a WONTFIX because you can click on the header and sort the list
this way?

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

I don't see a columnpicker in the dialogs, so i guess this is worksforme :)
morphing into another problem isn't a great idea in general, so if you really
don't want the header, file another bug. (but imho, there should be one. It is a
normal list, like the other managers, so should have a header. prefs was
somewhat special)

Comment 7

[Andreas Kunz]

Comment on attachment 139672 [details] [diff] [review]
patch

Damn, I didn't misread this bug, I misread it TOTALLY!

Comment 8

[Andreas Kunz]

WFM