1259253 - Add "Synced Tabs" feature to history panel

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Bryan Munar (:bkmunar)]

1. Add "Synced Tabs" cell to history panel
2. Display the Remote Tabs panel data in this new page

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

definitely not perfect, but did what I could. Whoever gets to it first (like always!), but also would like two eyes on it!

Comment 2

[Robin Andersen [:tecgirl]]

Comment on attachment 8745073 [details] [review]
PR

It's close! see http://c.tecgirl.com/fnl9

The Synced devices icon should center with the favicons, as well as the text labels, they should line up with the cells below. 

The default favicon letters are showing up fuzzy for me, how are these rendered?

On a 6s+, the top and left borders of the favicons appears to be 2px instead of 1.

The caret. It appears vertically stretched and is a different asset than used on Bookmarks. It looks close to what's in the mock, but is stretched. http://c.tecgirl.com/fneb
We need to unify this asset.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8745073 [details] [review]
PR

Left feedback on the PR. Good start!

Comment 4

[Bryan Munar (:bkmunar)]

Comment on attachment 8745073 [details] [review]
PR

round 2

Comment 5

[Stephan Leroux [:sleroux]]

Left more feedback on the PR.

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8745073 [details] [review]
PR

Final round of nits but good to go!

Comment 7

[Bryan Munar (:bkmunar)]

https://github.com/mozilla/firefox-ios/pull/1738/commits/82a90c988444d35916ab973d645adeea93d20535