Closed
Bug 1259495
Opened 8 years ago
Closed 8 years ago
mailnews/local/src/nsLocalUndoTxn.cpp:553:15: error: ‘class nsIAtom’ has no member named ‘EqualsUTF8'
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 48.0
People
(Reporter: ishikawa, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.08 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
It is great to see C-C build working again, but when I refreshed the source a few hours ago, I got a compilation bug. mailnews/local/src/nsLocalUndoTxn.cpp:553:15: error: ‘class nsIAtom’ has no member named ‘EqualsUTF8’ aEvent->EqualsUTF8(NS_LITERAL_CSTRING("FolderLoaded"))) ^ Probably a method was decprecated or something.
Comment 1•8 years ago
|
||
I suppose, it's bug 1257128.
Updated•8 years ago
|
Component: Message Reader UI → Backend
Product: Thunderbird → MailNews Core
Comment 2•8 years ago
|
||
Sorry for the breakage! I think you can fix it by (a) changing the NS_LITERAL_CSTRING to NS_LITERAL_STRING, and (b) calling ScriptableEquals() instead of EqualsUTF8().
Comment 3•8 years ago
|
||
This: aEvent->ScriptableEquals(NS_LITERAL_STRING("FolderLoaded"))) ends in this error: z:/Mozilla/comm-central/mailnews/local/src/nsLocalUndoTxn.cpp(553) : error C2660: 'nsIAtom::ScriptableEquals' : function does not take 1 arguments I have zero knowledge of c++ As I understand, EqualsUTF8 was this AtomImpl::EqualsUTF8(const nsACString& aString) { return CompareUTF8toUTF16(aString, nsDependentString(mString, mLength)) == 0; } Would it work, using CompareUTF8toUTF16 somehow?
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #4) > Created attachment 8734533 [details] [diff] [review] > This might work. SM: /home/hafi/moz-work/src/mailnews/local/src/nsLocalUndoTxn.cpp:554:32: error: ‘NS_LITERAL_STRING’ was not declared in this scope aEvent->ScriptableEquals(NS_LITERAL_STRING("FolderLoaded", &isEqual)); ^ (deps) /home/hafi/moz-work/src/mozilla/intl/icu/source/i18n/collationcompare.cpp /home/hafi/moz-work/src/mozilla/config/rules.mk:918: recipe for target 'nsLocalUndoTxn.o' failed make[4]: *** [nsLocalUndoTxn.o] Error 1
Comment 6•8 years ago
|
||
Are just the braces wrong and it should be: aEvent->ScriptableEquals(NS_LITERAL_STRING("FolderLoaded"), &isEqual) ?
Updated•8 years ago
|
Blocks: 1257128
Keywords: regression
Comment 7•8 years ago
|
||
Oops, sorry.
Updated•8 years ago
|
Attachment #8734533 -
Attachment is obsolete: true
Comment 8•8 years ago
|
||
Suite seems to compile but now hits a VS2015 char16_t error. Unrelated to this one. Someone goofed in mozilla code so can't test right now.
Updated•8 years ago
|
Summary: C-C TB compilation failure: mailnews/local/src/nsLocalUndoTxn.cpp:553:15: error: ‘class nsIAtom’ has no member named ‘EqualsUTF8’ aEvent->EqualsUTF8(NS_LITERAL_CSTRING("FolderLoaded"))) ^ → mailnews/local/src/nsLocalUndoTxn.cpp:553:15: error: ‘class nsIAtom’ has no member named ‘EqualsUTF8'
Updated•8 years ago
|
Attachment #8734538 -
Flags: feedback?(n.nethercote)
Updated•8 years ago
|
Attachment #8734538 -
Flags: review?(rkent)
Comment 9•8 years ago
|
||
My SM-Trunk Linux x86_64 builds successfully now. Because $OBJDIR is always deleted before compiling?
Comment 10•8 years ago
|
||
Comment on attachment 8734538 [details] [diff] [review] This might work, take 2. Review of attachment 8734538 [details] [diff] [review]: ----------------------------------------------------------------- OK LGTM.
Attachment #8734538 -
Flags: review?(rkent) → review+
Comment 11•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/ed69d0332588
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Updated•8 years ago
|
Attachment #8734538 -
Flags: feedback?(n.nethercote)
You need to log in
before you can comment on or make changes to this bug.
Description
•