Closed
Bug 1259733
Opened 8 years ago
Closed 8 years ago
forward-declare nsIDocument in nsCSSFrameConstructor.h
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
3.87 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
This is sufficient for nsCSSFrameConstructor.h's needs, and the corresponding C++ file already includes nsIDocument.h.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8734733 -
Flags: review?(dholbert)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8734733 [details] [diff] [review] forward-declare nsIDocument in nsCSSFrameConstructor.h Review of attachment 8734733 [details] [diff] [review]: ----------------------------------------------------------------- > forward-declare nsIDocument in nsCSSFrameConstructor.h; r=dholbert This commit message is a bit misleading, since really most of the patch is doing something else (touching other files). Probably worth broadening the commit message to mention the overall point, & to not imply that this is a nsCSSFrameConstructor.h-specific patch. Something like the following would sum this patch up better, I think: > Remove unnecessary nsIDocument #includes in several animation & layout headers where a forward-decl will suffice. r=me, in any case.
Attachment #8734733 -
Flags: review?(dholbert) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8fa535b41cad
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•