Closed
Bug 1259784
Opened 8 years ago
Closed 8 years ago
Add a test that would catch reporting exceptions in the callback's compartment, not the unwrapped callback's compartment
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
I tried breaking this and running the wpt tests in testing/web-platform/tests/html/webappapis/scripting/processing-model-2/ and none of them failed. This is not helpful.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8734806 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Updated•8 years ago
|
Whiteboard: btpp-active
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8734806 [details] [diff] [review] Add some web platform tests that ensure that error events are fired on the window an event listener comes from, even if it's attached to an event target in a different window, and no matter how it got there Review of attachment 8734806 [details] [diff] [review]: ----------------------------------------------------------------- I think this is fine. ::: testing/web-platform/meta/MANIFEST.json @@ +34858,5 @@ > } > ] > }, > "testharness": { > + "html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1.html": [ Note that this conflicts with bug 785941. ::: testing/web-platform/tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1.html @@ +1,3 @@ > +<!doctype html> > +<meta charset=utf-8> > +<title></title> Titles for all of those would be nice.
Attachment #8734806 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
> Note that this conflicts with bug 785941.
Yeah, adding new wpt tests in our setup slightly sucks like that. I'll deal with the merge.
I'll try to add meaningful titles other than just "enumerating all combinations, 1 of 4" or something.
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d5486d4fde02
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•