126003 - [FIX]target="_self" becomes target="_top" with browser.block.target_new_window

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P1)

Description

[Jonas Jørgensen]

Open the testcase, click the link. Expected results: Opens in top frame. Actual:
Opens in full window.

Comment 1

[Jonas Jørgensen]

Attachment: testcase

Comment 2

[Adrian Ulrich]

wfm on Linux / Build 2002021308

Comment 3

[Jonas Jørgensen]

Well, it doesn't work in 2002021203...

Adrian: Are you sure you have browser.target_new_blocked switched on?

Comment 4

[Adrian Ulrich]

Uuuppss.. sorry..

i didn't read the summary field carefully enough!

With:
all.js:pref("browser.target_new_blocked", true);

It _doesn't_ work on linux build 2002021308

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 6

[Jonas Jørgensen]

<offtopic>
Bz: Just out of curiosity, why did you add the 'patch' keyword? According to
http://bugzilla.mozilla.org/describekeywords.cgi, it tracks patches "by
individuals without direct code check in privileges", but you do have a CVS
account (don't you?), so why the keyword?
</offtopic>

Comment 7

[Boris Zbarsky [:bzbarsky]]

<offtopic>
Habit from when I didn't have a CVS account.  :)
</offtopic>

Comment 8

[Akkana Peck]

Looks reasonable to me ... Boris, did you want to take this bug back?  You can
have r=akkana on it.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Um... sure.

Comment 10

[rpotts (gone)]

Comment on attachment 69963 [details] [diff] [review]
Proposed patch

sr=[e-mail]

Comment 11

[Jonas Jørgensen]

browser.target_new_blocked has been renamed to browser.block.target_new_window.
Updating summary.

Boris: Now that this pref is exposed to the public (bug 78037), do you think it
might be worth to try to get this into 0.9.9?

Comment 12

[Boris Zbarsky [:bzbarsky]]

Frankly, no.  Not that many places use target="_self" and 0.9.9 is pretty much
locked down at this point...

Comment 13

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 69963 [details] [diff] [review]
Proposed patch

Boris came to his senses and asked for approval of this.

a=shaver for 0.9.9.  (Also recording r=akkaka with the patch manager.)

Comment 14

[Boris Zbarsky [:bzbarsky]]

checked in for 0.9.9 (pre-branch).

Comment 15

[Jonas Jørgensen]

Verified on build 2002030913 from 0.9.9 branch.