1260061 - [GTK3] less padding in buttons

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P4)

Description

[daniel]

Attachment: firefox_gtk_button_width_border.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160304160129

Steps to reproduce:

Look at a <button> in Firefox 45 vs 44. (<input type="submit"> and the like also work.


Actual results:

Button is very wide and has lots of empty space between the button contents and the edge of the button.  Ff45 button is wider than normal GTK button.  Ff44 is smaller than both.


Expected results:

Less wide button.

I think this is related to the change for bug1257811 which adds GTK border sizes to the widget twice:
https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/gtk3drawing.cpp#l2706
https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/gtk3drawing.cpp#l2714
The double usage was exposed by bug1257811 when it took the inhtml check out.

Comment 1

[Karl Tomlinson (:karlt)]

I think the inhtml check was removed in https://hg.mozilla.org/mozilla-central/rev/3ae71e279abd
but AFAIK the border is only added once.  Border and padding are additive.

How does the new padding compare to that in togglebutton in gtk3-widget-factory, or in the buttons of the "save page" dialog?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I see 1px difference between system button size (28px) and inhtml Firefox button size (29px). System Fedora 22, gtk3-3.16.7.

It may be caused by different font metrics in Firefox, AFAIK we have a bug for that somewhere but I can't find it now.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Non-native theme fixed this.