1260181 - [e10s] Crashed tab page does not offer crash report submission

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[The 8472]

I have had 3 content process crashes today, when the crashed tab page came up it only contained the text
> Bad news first: This tab has crashed
> Now for the good news: You can just close this tab, restore it or restore all your crashed tabs."
and two buttons close tab, restore this tab.

I.e. the checkbox to submit the crash report and the button "restore all crashed tabs" button were missing.

The about:crashes page contains links to https://crash-stats.mozilla.com/about/throttling for each of the crashes.

Corresponding crash files can be found in %appdata%\Mozilla\Firefox\Crash Reports\pending

Is this intended behavior or a bug? I'm asking because I wanted to see whether the crash signature was associate with a known bug, but that's not possible/easy when the report is not submitted.

Comment 1

[The 8472]

Not sure if it's related, but the unsubmitted report does not immediately show up in about:crashes, it seems to require a restart.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hoping someone from our QA team can see if they can reproduce this. I have an add-on at https://addons.mozilla.org/en-US/firefox/addon/tab-crasher/ which can be used to crash the tab.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Also, The 8472 - do you see this if you use my add-on to crash a tab?

Comment 4

[The 8472]

yes, jimm already asked me to do that on IRC and it showed the same symptoms.

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: CrashScreenshot.jpg

Firefox: 48.0a1, Build ID  20160329030246
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0

Hi,

I have tested this issue on the latest Nightly (48.0a1) build, latest Aurora (47.0a2 - Build ID: 20160329004049) build, but I could not reproduce it. The check box to submit the crash report and the "restore all crashed tabs" button is displayed (see attachment).

Can you please retest this using a new profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E), and report back the results?

Thanks,
Cosmin.

Comment 6

[The 8472]

Testing with a new profile:

1. using the tab crasher does show the submission checkbox, it does not show the "restore all crashed tabs" button.
2. manually killing the content process does not show the submission checkbox

Since the report does show up in the "pending" directory I'm guessing it's a timing issue on my main profile (lots of tabs -> showing the crashed tab thing takes a while) and it misses the data somehow and thus treats it like a crash without data to report.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to The 8472 from comment #6)
> Testing with a new profile:
> 
> 1. using the tab crasher does show the submission checkbox, it does not show
> the "restore all crashed tabs" button.

Note that the "restore all crashed tabs" button is only displayed if there is more than one about:tabcrashed pages showing, which will only occur if you have more than one window open with crashed tabs.

> 2. manually killing the content process does not show the submission checkbox
> 

How are you manually killing the content process? If you're using SIGKILL, I'm pretty certain we cannot collect a crash report in that case. If you use SIGABRT, it should work.

> Since the report does show up in the "pending" directory I'm guessing it's a
> timing issue on my main profile (lots of tabs -> showing the crashed tab
> thing takes a while) and it misses the data somehow and thus treats it like
> a crash without data to report.

That's very odd, especially if you're using SIGKILL.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

And just to double check, what's the value of your pref "browser.tabs.crashReporting.sendReport"?

Comment 9

[The 8472]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #7)
> (In reply to The 8472 from comment #6)
> > Testing with a new profile:
> > 
> > 1. using the tab crasher does show the submission checkbox, it does not show
> > the "restore all crashed tabs" button.
> 
> Note that the "restore all crashed tabs" button is only displayed if there
> is more than one about:tabcrashed pages showing, which will only occur if
> you have more than one window open with crashed tabs.

What if it's only one window with multiple tabs which belonged to the same content process, i.e. all crashed at the same time?

> > 2. manually killing the content process does not show the submission checkbox

I'm on windows and using process explorer's kill process feature, which I guess is similar to SIGKILL in the sense that a process can do very little to intercept it.

Anyway, I was only testing this manually for the purpose of comparison.

> > Since the report does show up in the "pending" directory I'm guessing it's a
> > timing issue on my main profile (lots of tabs -> showing the crashed tab
> > thing takes a while) and it misses the data somehow and thus treats it like
> > a crash without data to report.
> 
> That's very odd, especially if you're using SIGKILL.

I did mention my "main profile" to highlight that this refers to my actual problem, which is just crashes happening without the option to submit reports, not the test profile where I tested manual killing.

So to clarify: Manually killing the content process shows similarity to my actual issue in so far as it does not offer to submit a crash report. But as already mentioned in comment 0 there is crash data in the pending folder for the actual crashes. Which lead me to the conclusion that the crashed tab view is somehow missing them, as if the process had crashed without producing one.

Comment 10

[The 8472]

(In reply to :Felipe Gomes (needinfo me!) from comment #8)
> And just to double check, what's the value of your pref
> "browser.tabs.crashReporting.sendReport"?

true

Comment 11

[Mike Conley (:mconley) (:⚙️)]

(In reply to The 8472 from comment #9)
> (In reply to Mike Conley (:mconley) - Needinfo me! from comment #7)
> > (In reply to The 8472 from comment #6)
> > > Testing with a new profile:
> > > 
> > > 1. using the tab crasher does show the submission checkbox, it does not show
> > > the "restore all crashed tabs" button.
> > 
> > Note that the "restore all crashed tabs" button is only displayed if there
> > is more than one about:tabcrashed pages showing, which will only occur if
> > you have more than one window open with crashed tabs.
> 
> What if it's only one window with multiple tabs which belonged to the same
> content process, i.e. all crashed at the same time?
> 

Then only the selected tab will show the about:tabcrashed page, and the background tabs are put into the "unrestored" state, where they restore on demand.

> > > 2. manually killing the content process does not show the submission checkbox
> 
> I'm on windows and using process explorer's kill process feature, which I
> guess is similar to SIGKILL in the sense that a process can do very little
> to intercept it.
> 
> Anyway, I was only testing this manually for the purpose of comparison.
> 
> > > Since the report does show up in the "pending" directory I'm guessing it's a
> > > timing issue on my main profile (lots of tabs -> showing the crashed tab
> > > thing takes a while) and it misses the data somehow and thus treats it like
> > > a crash without data to report.
> > 
> > That's very odd, especially if you're using SIGKILL.
> 
> I did mention my "main profile" to highlight that this refers to my actual
> problem, which is just crashes happening without the option to submit
> reports, not the test profile where I tested manual killing.
> 
> So to clarify: Manually killing the content process shows similarity to my
> actual issue in so far as it does not offer to submit a crash report. But as
> already mentioned in comment 0 there is crash data in the pending folder for
> the actual crashes. Which lead me to the conclusion that the crashed tab
> view is somehow missing them, as if the process had crashed without
> producing one.

Let's go back to your default profile for now. If you use my Tab Crasher add-on to crash the content process, is a crash report created?

And to be clear, if you open up the pending crash report folder for your profile, and _then_ you use Task Manager to kill the content process, is a new pending crash report inserted into the folder?

Comment 12

[The 8472]

I can't reproduce it anymore on current nightlies, so I'll close it for now. Will reopen should it occur again.