1260272 - Add a jsapi-test that creates multiple JSRuntimes in different threads

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

In response to a question on dev.tech.js-engine today.

We already have code for creating a second JSRuntime on a thread in shell/js.cpp, but it's not the simplest possible straight-line code. I dunno, seems like something we might as well smoke-test.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1: Whitespace style nits in jsapi-tests/tests.h

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2: Add a test that JS_NewRuntime works on threads and multiple threads can run code, racing freely

(The fork-join code is stolen from testThreadingExclusiveData.cpp.)

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8735612 [details] [diff] [review]
Part 1: Whitespace style nits in jsapi-tests/tests.h

Review of attachment 8735612 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, those have always bugged me.

Comment 4

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e095aa245ac330e3978bd169f27ccf23fd30020
Bug 1260272 - Part 1: Whitespace style nits in jsapi-tests/tests.h. r=terrence.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dacf02bb0ef6f8adde5f4085b9c3c669fdb2f60
Bug 1260272 - Part 2: Add a test that JS_NewRuntime works on threads and multiple threads can run code, racing freely. r=terrence.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This and bug 1255128 are backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/242bab2c3b06 for breaking android cpp tests: https://treeherder.mozilla.org/logviewer.html#?job_id=27166818&repo=mozilla-inbound