1260297 - [RTL][Eyedropper] prefix character "#" of color value moves to position start or end

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[magicp]

Attachment: move prefix character position of color value in RTL locales.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160328030215

Steps to reproduce:

1. Start RTL locales Nightly (e.g. Arabic)
2. Go to about:home
3. Open DevTools > Eyedropper
4. Move eyedropper on the page


Actual results:

prefix character "#" of color value moves to position start or end by color value.


Expected results:

prefix character position does not move.

Comment 1

[Patrick Brosset <:pbro>]

Triaging (filter on CLIMBING SHOES).

Comment 2

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1260297 - Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales.

Review commit: https://reviewboard.mozilla.org/r/61972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61972/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8767505 [details]
Bug 1260297 - Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales.

https://reviewboard.mozilla.org/r/61972/#review59228

Seems reasonable to me, thanks for taking a look!

Comment 4

[Ian Moody [:Kwan] (UTC+1)]

Thanks for the review jryans.

Wouldn't have merited a try run on it's own, but it got a ride-along with bug 1171614:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99ca357f2ae3

Comment 5

[Patrick Brosset <:pbro>]

Note that I'm deleting the eyedropper in bug 1262439 and replacing it with a new implementation (for the devtools.html project, in order to remove XUL). So that means this will need to be fixed again soon, after I land my change, unfortunately.

Comment 6

[Patrick Brosset <:pbro>]

Actually, since the fix is essentially 1 line (direction: ltr;), I might add it to bug 1262439 so it's already fixed in the new implementation too.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/263be4d56ba6
Force LTR direction for the eydropper color value so the # character doesn't move depending on colour in RTL locales. r=jryans

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/263be4d56ba6

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Beta 48.0b1 (Arabic) on Windows 7 , 64 Bit !

This bug's fix is verified with latest Beta 

This bug's fix is verified with latest Beta(Arabic)

Built Id   :  20161010144024 
User Agent :  Mozilla/5.0 (WindowsNT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
[bugday-20161012]