1260377 - Fix CDMProxy::SetServerCertificate null dereference to avoid crashing

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[James Cheng[:JamesCheng]]

CDMProxy::SetServerCertificate forgets to malloc before using.
Quick fix this potential crash issue.

https://dxr.mozilla.org/mozilla-central/rev/63be002b4a803df1122823841ef7633b7561d873/dom/media/eme/CDMProxy.cpp#337

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Fix-CDMProxy-SetServerCertificate-crash-.patch

carry r+ from bug 1234976 comment 29.

Comment 2

[James Cheng[:JamesCheng]]

attach treeherder result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c9f5d1d727e

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/690f9c2a909b45dbbc98c3d2694a0d626edb0f5a
Bug 1260377 - Fix CDMProxy::SetServerCertificate crash since null pointer. r=cpearce

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Will want to uplift this.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/690f9c2a909b

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8735757 [details] [diff] [review]
Fix-CDMProxy-SetServerCertificate-crash-.patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Potential for some EME JavaScript players to crash if they call a function of the EME API. This function isn't used by Adobe EME, but if a site calls this regardless, we can crash (null pointer dereference, not exploitable).
[Describe test coverage new/current, TreeHerder]: We don't call this specific path, as Adobe's EME plugin and our baseline clearkey EME implementation doesn't use this function.
[Risks and why]: Low; it's just allocating a struct.
[String/UUID change made/needed]: None.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8735757 [details] [diff] [review]
Fix-CDMProxy-SetServerCertificate-crash-.patch

Crash fix, Aurora47+

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bdce1c532b56