Closed Bug 1260492 Opened 8 years ago Closed 8 years ago

Wrong window tabs get shared when switching windows as tab sharing is starting

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: Mardak, Unassigned)

References

Details

This is causing problems for implementing bug 1258318 as it opens a new window for facebook share dialog.

This is caused by the tab sharing code just grabbing the most recent window instead of remembering what window initiated tab sharing.

Some reason I feel that there's a bug for this already...
My current thought is each LoopUI added by bootstrap.js would remember when it most recently opened the loop panel (LoopUI.openPanel). This allows us to update all references of Services.wm.getMostRecentWindow("navigator:browser") from MozLoopAPI to instead iterate over "navigator:browser"s and select the most recent browser window that opened the panel.

dmose said he had some thoughts in standup.
Flags: needinfo?(dmose)
dmose was just clarifying the need for this. An example of the bug is the facebook dialog opening in a new window causing getMostRecentWindow to show the infobar and share the facebook dialog instead of the window the user was interacting with. This is partially caused by the delay between starting a conversation and tab sharing (from setting up server connections and sdk) and racing with if the user switched windows in that time.
Flags: needinfo?(dmose)
Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.