1260681 - bundle upload does not hard fail for missing credentials

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Hal Wine [:hwine] use NI!]

when credentials are not installed, or are invalid, for upload of bundles to S3, no explicit error is given. This made diagnosis of bug 1260652 harder than it should have been :)

Comment 2

[Gregory Szorc [:gps]]

I'll fix this and the problem of advertising bundles that didn't upload properly.

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: sripts/generate-hg-s3-bundles: check for errors (bug 1260681); r?fubar

TIL that Python futures in concurrent.futures swallow exceptions. I
thought they were behaving like Python threads where an exception in any
thread would terminate program execution. It turns out you need to
explicitly check Future.result() or Future.exception() to see if
the thing raised an exception.

Tests demonstrating the script fails under various conditions have been
added.

Review commit: https://reviewboard.mozilla.org/r/43223/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43223/

Comment 4

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8736338 [details]
MozReview Request: sripts/generate-hg-s3-bundles: check for errors (bug 1260681); r?fubar

https://reviewboard.mozilla.org/r/43223/#review39831

lgtm

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/66cb0cd44d788b1281e6efc3fd8b6e0b52933c53
sripts/generate-hg-s3-bundles: check for errors (bug 1260681); r=fubar

Comment 6

[Gregory Szorc [:gps]]

This was fixed 22 days ago.