1260839 - Selected range doesn't gets canceled when I click on empty space in Console

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160326030430
STR:
1. Open data:text/html,<select><option>1<option>2</select><style>a{b:c;d:e;}
2. Open Console
3. Select a word, then click on empty area below messages in Console

AR:  Selected range doesn't gets canceled
ER:  Selected range should be canceled for everything to work fine. See (4) in bug 1239992 comment 11

This is regression from bug 1237368. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=ebaf5066ddd3c718cc2bd421f340809e6ab6f260&tochange=1aed451f1502dc6437d172c6a3e87f36a2a64bcc

Comment 1

[Brian Grinstead [:bgrins]]

I think this is because of -moz-user-select: text on the #output-container but it should be on #output-wrapper

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1260839 - Move -moz-user-select: text up to #output-wrapper so selection can be cancelled by clicking below messages;r=vporof

Review commit: https://reviewboard.mozilla.org/r/43281/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43281/

Comment 3

[Brian Grinstead [:bgrins]]

This might also fix Bug 1260821

Comment 4

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1381ff4941ee

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 8736424 [details]
MozReview Request: Bug 1260839 - Move -moz-user-select: text up to #output-wrapper so selection can be cancelled by clicking below messages;r=vporof

https://reviewboard.mozilla.org/r/43281/#review41703

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/976abe6c1b31

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/976abe6c1b31

Comment 8

[arni2033]

Fixed on:   Win7_64, Nightly 48, 32bit, ID 20160409030219