1261137 - Add groups in Settings > Advanced

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Like bug 1260930, I think we need a grouping of "Data usage" in our Advanced settings.

We can place this at the top of the list for now.

Data usage
---
Show images

Show web fonts

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: settings_data_usage.png

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1261137 - Add "Data usage" group in Settings > Advanced. r?ahunt

Review commit: https://reviewboard.mozilla.org/r/43573/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43573/

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I don't think we should tuck this at the bottom of the list. But to put it at the top, we'll need to group and label the other items in this list too.

Sorry, but let's hold off on this for now until we can label the other sections. :)

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

ok

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

It looks like the whole "Advanced" page could benefit from some grouping. Let's repurpose this bug as such.

+------------------------------------+
|                                    |
|  Advanced                          |
|                                    |
+------------------------------------+
|                                    |
|  Auto update                       |
|                                    |
|  Restore tabs                      |
|                                    |
|  Character encoding                |
|                                    |
|                                    |
|  [Data saver]                      |
|                                    |
|  Show images                       |
|                                    |
|  Show web fonts                    |
|                                    |
|                                    |
|  [Media]                           |
|                                    |
|  Plugins                           |
|                                    |
|  Allow autoplay                    |
|                                    |
|                                    |
|  [Developer tools]                 |
|                                    |
|  Remote debugging via USB          |
|                                    |
|  Remote debugging via Wi-Fi        |
|                                    |
|                                    |
+------------------------------------+


To be clear, the groups are in square brackets above. 

Data saver

Media

Developer tools

Comment 6

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1261137 - Add groups in Settings > Advanced. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/45859/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45859/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8740658 [details]
MozReview Request: Bug 1261137 - Add groups in Settings > Advanced. r=sebastian

https://reviewboard.mozilla.org/r/45859/#review42567

::: mobile/android/base/resources/xml/preferences_advanced.xml:74
(Diff revision 1)
> +    </PreferenceCategory>
> +
>  
>      <SwitchPreference android:key="devtools.remote.wifi.enabled"
>                        android:title="@string/pref_developer_remotedebugging_wifi" />
>  
>      <org.mozilla.gecko.preferences.AlignRightLinkPreference android:key="android.not_a_preference.remote_debugging.link"
>                                                              android:title="@string/pref_learn_more"
>                                                              android:persistent="false"
>                                                              url="https://developer.mozilla.org/docs/Tools/Remote_Debugging/Debugging_Firefox_for_Android_with_WebIDE" />
>  

The WiFi preferences is outside of the developer tools category.

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/196a0e282b3e33aa3d82ae6f3e7d21390d2a60fd
Bug 1261137 - Add groups in Settings > Advanced. r=sebastian

Comment 9

[:Margaret Leibovic]

(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Comment on attachment 8740658 [details]
> MozReview Request: Bug 1261137 - Add groups in Settings > Advanced.
> r=sebastian
> 
> https://reviewboard.mozilla.org/r/45859/#review42567
> 
> ::: mobile/android/base/resources/xml/preferences_advanced.xml:74
> (Diff revision 1)
> > +    </PreferenceCategory>
> > +
> >  
> >      <SwitchPreference android:key="devtools.remote.wifi.enabled"
> >                        android:title="@string/pref_developer_remotedebugging_wifi" />
> >  
> >      <org.mozilla.gecko.preferences.AlignRightLinkPreference android:key="android.not_a_preference.remote_debugging.link"
> >                                                              android:title="@string/pref_learn_more"
> >                                                              android:persistent="false"
> >                                                              url="https://developer.mozilla.org/docs/Tools/Remote_Debugging/Debugging_Firefox_for_Android_with_WebIDE" />
> >  
> 
> The WiFi preferences is outside of the developer tools category.

Oops, good catch. I also failed to move the character encoding item to up higher. I fixed both issues before landing.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/196a0e282b3e

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2016-04-18-11-10-29.png

Verified as fixed using:
Device: Nexus 7 (Android 5.1)
Build: Firefox for Android 48.0a1 (2016-04-17)