1261676 - Test that disabling PSK suites also disables resumption

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Martin Thomson [:mt:]]

Attachment: 0001-Disable-PSK-and-disable-resumption.patch

I wrote a test for this.  It's probably useful.

Comment 1

[Eric Rescorla (:ekr)]

Comment on attachment 8737601 [details] [diff] [review]
0001-Disable-PSK-and-disable-resumption.patch

Review of attachment 8737601 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: external_tests/ssl_gtest/ssl_loopback_unittest.cc
@@ +1012,5 @@
> +  Connect();
> +  SendReceive();
> +  CheckKeys(ssl_kea_ecdh, ssl_auth_rsa);
> +  DataBuffer psk1(c1->extension());
> +  EXPECT_EQ(psk1.len(), 0UL);

Is there a reason to make a DataBuffer? Can't you interrogate extension directly

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8737601 [details] [diff] [review]
0001-Disable-PSK-and-disable-resumption.patch

Review of attachment 8737601 [details] [diff] [review]:
-----------------------------------------------------------------

> Is there a reason to make a DataBuffer? Can't you interrogate extension directly

That spun off an investigation.  I discovered several things:

1. we leak the DummyPrSocket on every test
2. the resume TLS 1.3 twice test never bothered to capture the PSK extension
3. because I cribbed from that test without double-checking, neither did this test
4. when we disable all the PSK suites, we still send the PSK extension (this is benign, but we shouldn't)

I will work on a patch during this upcoming breakfast meeting.

Comment 3

[Martin Thomson [:mt:]]

http://codereview.appspot.com/296860043

Comment 4

[Martin Thomson [:mt:]]

See rietveld request above.

Comment 5

[Martin Thomson [:mt:]]

See rietveld request: https://codereview.appspot.com/292550043

Comment 6

[Eric Rescorla (:ekr)]

LGTM in Rietveld.

Comment 7

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/39dd42b2a731

Comment 8

[Martin Thomson [:mt:]]

Oops https://hg.mozilla.org/projects/nss/rev/58d4353a2646