Closed
Bug 1261707
Opened 8 years ago
Closed 8 years ago
merge the various versions of setupComposeWin() in TB mozmill tests
Categories
(Thunderbird :: Testing Infrastructure, enhancement)
Thunderbird
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 48.0
People
(Reporter: aceman, Assigned: aceman)
Details
Attachments
(1 file)
|
25.72 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
The helper function setupComposeWin() exists in several tests in mail/test/mozmill/composition, with slight variations. But their purpose is the same. I propose to merge them into one function in test-compose-helpers.js. I have the patch ready, but can't produce a successful try run due to bug 1261602 (crash in composition/test-image-insertion-dialog.js which may affect other tests in the folder).
|
||
Comment 1•8 years ago
|
||
Bug 1261602 is fixed.
Thanks, pushed: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b8c83ed17a9e
Attachment #8737913 -
Flags: review?(mkmelin+mozilla)
Run seems successful (OS X and Win), excluding the known failures that ware fixed since (backing out the reply identity patch).
Status: NEW → ASSIGNED
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8737913 [details] [diff] [review] patch Review of attachment 8737913 [details] [diff] [review]: ----------------------------------------------------------------- Yes, lgtm! r=mkmelin
Attachment #8737913 -
Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/38259e9e74a91e197c67ad820a1163e8d26254b7 Bug 1261707 - merge the various versions of setupComposeWin() in TB mozmill tests. r=mkmelin a=aleth
|
|
||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
You need to log in
before you can comment on or make changes to this bug.
Description
•