Closed
Bug 1261873
Opened 8 years ago
Closed 8 years ago
windows 7 cpu/mem counters are showing up as values of 0 after changing the process names
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jmaher, Unassigned)
References
Details
Attachments
(1 file)
in bug 1114647 a lot of work was done to change the process names for the child process, but in the act of doing so it appears we have missing data: https://treeherder.mozilla.org/perf.html#/alerts?id=708
Reporter | ||
Comment 1•8 years ago
|
||
ni myself to ensure that I follow up here- so far I have been putting print statements in cmanager_win32.py to determine what is getting registered, it appears that on the first counter that we register, we never complete the addition of it, somehow we are hanging in a loop and never registering other counters in the loop, nor finishing the registration which then causes us to never start collecting.
Flags: needinfo?(jmaher)
Reporter | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44557/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/44557/
Attachment #8738480 -
Flags: review?(wlachance)
Reporter | ||
Comment 3•8 years ago
|
||
we were throwing an exception in code that effectively looks like: expanededCounters = None expandedCounters.append(...) this is easy to solve and when we do we go back to our previous values.
Flags: needinfo?(jmaher)
Comment 4•8 years ago
|
||
Comment on attachment 8738480 [details] MozReview Request: Bug 1261873 - windows 7 cpu/mem counters are showing up as values of 0 after changing the process names. r?wlach https://reviewboard.mozilla.org/r/44557/#review41285
Attachment #8738480 -
Flags: review?(wlachance) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70e457189e30
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•